Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): not being able to zoom into live photos #14608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Dec 9, 2024

Description

This PR moves the handling for toggling the live photo from the native player to the gallery viewer.

This is unfortunately much less efficient:

  1. It only starts loading the video when the toggle button is clicked instead of preloading it
  2. Each toggle re-renders the image
  3. Each toggle to the motion part re-initializes the player and video

As such, this change adds a delay to the toggling and increases resource usage, and is hence intended to be a hot-fix pending a better solution.

Fixes #14553

How Has This Been Tested?

Tested with a release build on iOS, confirming that pinching and panning work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multitouch completely broken in Immich iOS app 1.122.0
1 participant