-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: original-sized previews for RAW images #14446
base: main
Are you sure you want to change the base?
Conversation
f2b631a
to
54b91b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I mostly looked at the server code, where I think it needs some more polishing.
Re: caching, this also affects the case where the user zooms in and no extracted image exists, right? It will load the preview again.
076d59d
to
a7a9b4d
Compare
a7a9b4d
to
34592b3
Compare
any more comments from maintainers to get this merged, so that I can continue with previews of other images? |
@eligao no rush here |
I think we should wait until we're done with hot fixes for the current release. |
For a DNG image with a resolution of 5376x3956 and 41.3MiB in size, the following variants are generated using the default settings:
These generated variants seem larger than expected and don't match the configured settings, with the preview and original being identical. It's also strange that the resolution has slightly changed. |
nice catch, the file sizes are indeed wrong, let me fix that and add checks to tests. |
Hi again @eligao! We've been talking about the PR and think there are a few changes it'll need for it to be merge-able.
|
image.extractEmbedded
in options is set, it will attempt to extract the JPG/Preview from RAW images.extractEmbedded
is not set, it will fall back to creating a full-sized image from RAW.AssetFileType.converted
file.AssetMediaSize.Original
size is available under theviewThumbnail
APIAssetMediaSize.Original
preview via theviewThumbnail
APISome loose ends: