Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitouch completely broken in Immich iOS app 1.122.0 #14553

Open
1 of 3 tasks
Stooovie opened this issue Dec 7, 2024 · 17 comments · May be fixed by #14608
Open
1 of 3 tasks

Multitouch completely broken in Immich iOS app 1.122.0 #14553

Stooovie opened this issue Dec 7, 2024 · 17 comments · May be fixed by #14608

Comments

@Stooovie
Copy link

Stooovie commented Dec 7, 2024

The bug

Pinch to zoom is completely impossible in 1.122.0. The image just dances around erratically, Details pane goes up, but the image doesn't zoom in, at all. Pinch to zoom is 100% impossible, double tap to zoom also. See video of me doing the same thing in Immich and then in Photos app. It is not fixed by force quitting the app or rebooting the phone.

The OS that Immich Server is running on

Proxmox LXC (Debian)

Version of Immich Server

1.122.1

Version of Immich Mobile App

1.122.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

version: "3.8"

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:release
    volumes:
      - /media/Public/immich:/usr/src/app/upload
    env_file:
      - .env
    ports:
      - 2283:2283
    depends_on:
      - redis
      - database
    restart: always

  immich-machine-learning:
    container_name: immich_machine_learning
    image: ghcr.io/immich-app/immich-machine-learning:release
    volumes:
      - ${UPLOAD_LOCATION}:/media/Public/immich
      - model-cache:/cache
    env_file:
      - .env
    restart: always

  redis:
    container_name: immich_redis
    image: redis:6.2
    restart: always

  database:
    container_name: immich_postgres
    image: tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    env_file:
      - .env
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
      PG_DATA: /var/lib/postgresql/data
    volumes:
      - pgdata:/var/lib/postgresql/data
    restart: always

volumes:
  pgdata:
  model-cache:

Your .env content

DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_PASSWORD=postgres
DB_DATABASE_NAME=immich
REDIS_HOSTNAME=immich_redis
UPLOAD_LOCATION=/root/media
TYPESENSE_API_KEY=some-random-text
PUBLIC_LOGIN_PAGE_MESSAGE=
IMMICH_WEB_URL=http://immich-web:3000
IMMICH_SERVER_URL=http://immich-server:3001
IMMICH_MACHINE_LEARNING_URL=http://immich-machine-learning:3003

Reproduction steps

  1. Launch Immich on iPhone
  2. Open a photo
  3. Pinch to zoom
    ...

Relevant log output

No response

Additional information

IOS 18.1.1, iPhone 13 Pro
@alextran1502
Copy link
Contributor

Hmm, it is hard to replicate without seeing your hand gesture. I tried on my iPhone 16 and pinch to zoom works normally for remote/local assets 🤔 Can you record how do you normally pinch to zoom?

@Stooovie
Copy link
Author

Stooovie commented Dec 7, 2024

Yes I can, here

As you can see, no issue whatsoever in Photos.

@drew654
Copy link

drew654 commented Dec 7, 2024

I have the exact same issue starting with 1.122.0 as well. Galaxy S22, One UI 6.1, Android 14.

@drew654
Copy link

drew654 commented Dec 7, 2024 •
edited
Loading

I have the exact same issue starting with 1.122.0 as well. Galaxy S22, One UI 6.1, Android 14.

It seems to happen with only my heic pictures.

@secmaster
Copy link

secmaster commented Dec 8, 2024 •
edited
Loading

i have the same issue from the old ipad pro

@aetasoul
Copy link
Contributor

aetasoul commented Dec 8, 2024

Same issue with Google pixel 8 pro, only on some pictures.

@twilightty
Copy link

I'm having the same issue on Pixel 7, that occurs on some pics

@Ender-Wang
Copy link

What are those "some pictures" exactly? PNG, JPEG, HEIF, DNG?

@twilightty
Copy link

What are those "some pictures" exactly? PNG, JPEG, HEIF, DNG?

It happens with jpg, heic.

@alextran1502
Copy link
Contributor

@mertalev could it be some changes from the native video pr cause this issue? It is the most recent pr that touch this code, right?

Folks, can you guys provide the original photo that is having issue with pinch to zoom?

@twilightty
Copy link

twilightty commented Dec 9, 2024 •
edited
Loading

@alextran1502 hi, you can check out my video

https://youtu.be/3pFC-14TjyY?si=JUVSQ_EBR-PuiaJP

recorded on my pixel 7, the zoom is tested with both double tapping and pinching

@twilightty
Copy link

https://drive.proton.me/urls/A563WC3D5G#5VEcdi33Mrmc

and here goes the original photo.

@Stooovie
Copy link
Author

Stooovie commented Dec 9, 2024

What are those "some pictures" exactly? PNG, JPEG, HEIF, DNG?

It happens with jpg, heic.

It happens only with HEIC for me. Obviously I can't vouch for every one of them but I've tried a dozen each, JPEGs zoom fine, HEICs don't.

@alextran1502
Copy link
Contributor

I can reproduce on LivePhotos

@ahorseman
Copy link

Zoom doesn't work for me at all any more.

@mertalev
Copy link
Contributor

mertalev commented Dec 9, 2024

@mertalev could it be some changes from the native video pr cause this issue? It is the most recent pr that touch this code, right?

Folks, can you guys provide the original photo that is having issue with pinch to zoom?

If the issue is specific to live photos, then it could be explained by them being moved into the native player. Since the native player is a custom child component, things like pinch gestures might need to be more explicitly configured.

@alextran1502 alextran1502 mentioned this issue Dec 9, 2024
Closed
3 tasks
@sebinity
Copy link

sebinity commented Dec 9, 2024 •
edited
Loading

Confirming on my Pixel 6 Pro with 1.122.0:

  • jpg working fine
  • MP.jpg motion picture not zoomable
  • heic working
  • heic live photo not zoomable
  • mp4/mov generally not zoomable

I think, the video player might be a very likely target for this bug...

@mertalev mertalev linked a pull request Dec 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mobile): not being able to zoom into live photos immich-app/immich
10 participants
@secmaster @Stooovie @aetasoul @alextran1502 @Ender-Wang @ahorseman @drew654 @sebinity @twilightty @mertalev