enhancements for Onix 3 support #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julbouln
reviewed
Nov 23, 2022
| @@ -6,7 +6,7 @@ | |||
| module ONIX | |||
| class Contributor < SubsetDSL | |||
| element "SequenceNumber", :integer, :cardinality => 0..1 | |||
| element "ContributorRole", :subset, :shortcut => :role, :cardinality => 1..n | |||
| elements "ContributorRole", :subset, :shortcut => :roles, :cardinality => 1..n | |||
There was a problem hiding this comment.
To avoid API break, it would be nice to add a singular role method like for place https://github.com/immateriel/im_onix/blob/master/lib/onix/contributor.rb#L49
|
Hi, Nice contribution ! Just be careful not to break the API so we can integrate it in main branch. |
julbouln
reviewed
Nov 29, 2022
| end | ||
|
|
||
| def each(&block) | ||
| @reader.each do |node| |
There was a problem hiding this comment.
maybe add
return unless @readerbefore the iteration to avoid an exception if reader has not been called ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to open a PR from a fork (https://github.com/BookBub/im_onix) in case it's helpful, feel free to dismiss.
SimpleDelegator)Nokogiri::XML::Readerrather than a fullNokogiri::XML.parse- the latter pulls the entire onix file into memory first, while theReaderwill stream each node into memory, so is overall less memory intensive. This matches Cacofonix's strategy as well, which under benchmarking was faster than im_onix.