@@ -26,6 +26,15 @@ Also check the [changelog](./CHANGELOG.md) and open the on-development
2626changelog, it might be already fixed but hasn't published yet! Duplicate issues
2727are unnecessary.
2828
29+ Note to maintainer/contributor: When there's a bug discovered, make a test for
30+ it if possible. Use Deno's own testing tools:
31+ [ examples] ( https://github.com/ilo-token/ilo-token.github.io/blob/master/src/translator/test.ts ) .
32+ Then edit the issue to link the test in following format:
33+
34+ ``` md
35+ Test: [src/translator/test.ts "verb with adverb"](permalink including the lines)
36+ ```
37+
2938## [ Discussion] ( https://github.com/ilo-token/ilo-token.github.io/discussions )
3039
3140This GitHub repository have discussion, a dedicated forum page and shall serve
@@ -42,8 +51,10 @@ Please search first before opening a new page! Duplicate pages are unnecessary.
4251Before forking and editing, please claim an issue first or open an issue then
4352claim it. After that, you can start away. This is necessary to avoid wasted
4453duplicate efforts.
54+ [ The wiki] ( https://github.com/ilo-token/ilo-token.github.io/wiki ) contains
55+ useful information for contributors.
4556
46- You ** don't** have to do this if:
57+ You ** don't** have to open a new issue this if:
4758
4859- It is a contribution to the dictionary
4960- It is a minor edit e.g. a typo fix
@@ -52,11 +63,22 @@ Please don't do the following, we can do this ourselves.
5263
5364- Updating dependencies
5465
55- Additionally, please format the code when you make changes. We use Deno's
56- built-in formatter.
66+ More things to remember:
5767
58- [ The wiki] ( https://github.com/ilo-token/ilo-token.github.io/wiki ) contains
59- useful for contributors.
68+ - Keep the source code as runtime agnostic as possible. We target the browser
69+ and Deno. This is necessary because we use ` deno test ` . If a module is
70+ exclusive to one runtime, add a note above the code:
71+ ` // This code is browser/Deno only ` .
72+
73+ (The following aren't strict rules. It's perfectly fine to not follow any of
74+ these, we can adapt.)
75+
76+ - Ensure all the files are formatted: Run ` deno fmt ` .
77+ - Make sure you don't accidentally make more tests fail: Run
78+ ` deno test --parallel ` before and after making changes to the code. Some tests
79+ may already be failing.
80+ - Make use of linter: Run ` deno lint ` . If a lint rule is deemed unnecessary and
81+ more of an annoyance, open an [ issue] ( #issue ) . We can remove lint rules.
6082
6183As a thank you for contributing, you'll get a shout out in the changelog!
6284
@@ -86,6 +108,6 @@ themselves serves as a space for broader topics, not just ilo Token.
86108 programming language, it uses similar techniques found in programming language
87109 development e.g. parsing.
88110
89- These are unnoficial spaces and are not subject to the
111+ These are unofficial spaces and are not subject to the
90112[ Contributor Covenant Code of Conduct] ( https://github.com/ilo-token/ilo-token.github.io/blob/master/CODE_OF_CONDUCT.md ) .
91113Instead, each have its own rules and different moderators.
0 commit comments