Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Java JARS for Java 1.8 #129

Open
ikarosilva opened this issue Aug 5, 2016 · 7 comments
Open

Build Java JARS for Java 1.8 #129

ikarosilva opened this issue Aug 5, 2016 · 7 comments
Assignees

Comments

@ikarosilva
Copy link
Owner

No description provided.

@ikarosilva ikarosilva changed the title Build Java JARS for Java 1.88 Build Java JARS for Java 1.8 Aug 5, 2016
@ikarosilva
Copy link
Owner Author

Putting this on hold for now, until MATLAB uses Java 1.8 ( the R2016b is still on 1.7).

@cx1111
Copy link
Collaborator

cx1111 commented Nov 1, 2016

Hi Ikaro

For when the next MATLAB version comes out, is it done via this:

javac *.java jni/Rdsamp.java physiobank/*.java

in the src/org/physionet/wfdb directory?

@ikarosilva
Copy link
Owner Author

Hi,

The easiest way is simply running 'make' where the Makefile exists. It will call Eclipse headlessly and compile the jar using the information in the xml file.

@gabriel-limeira
Copy link

Ikaro, Octave is already using java 1.8. Java 1.8 will be used in the version of MATLAB, according to their site. I am using Octave in Linux, so I am not able to use the toolbox. I need it so much! Please help.
Is there a way for the time being to use a previous version of Octave an JDK? It cannot be done via my software repositories in Ubuntu, since openjdk7 is not even available.

@ikarosilva
Copy link
Owner Author

Hi,
The toolbox has the Java 1.8 dependencies compiled already (wfdb-app-JVM8-0-9-10.jar). The code has also been update in wfdbloadlib:

%Check if path has not been added yet
if(~isempty(strfind(ml_jar_version,'Java 1.7')))
    wfdb_path=[wfdb_path 'wfdb-app-JVM7-0-9-10.jar'];
elseif(~isempty(strfind(ml_jar_version,'Java 1.8')))
    wfdb_path=[wfdb_path 'wfdb-app-JVM8-0-9-10.jar'];
else
    error(['Cannot load WFDB JAR on unsupported JVM: ' ml_jar_version])
end

So can you please make sure you running the latest from Github ? If so, what error are you getting ?

@gabriel-limeira
Copy link

gabriel-limeira commented Apr 21, 2017 via email

@gabriel-limeira
Copy link

gabriel-limeira commented Apr 25, 2017

Ok, I have some news. First of all, I was mistaken, the version in the WFDB website is the same as in Git Hub. But the Java dependencies pŕovided in each zip file are different! The zip in Physionet website had versions 1.6 and 1.7. The zip file in github has versions 1.7 and 1.8. I don't know if you have just updated the (.jar) files, maybe that's the reason. The code that you said that you would update in wfdbloadlib (in github) is still in the old version, so I got the same error as before, even though the (.jar) file has been updated.

error: Cannot load WFDB JAR on unsupported JVM: Java 1.8.0_121
error: called from
wfdbloadlib at line 107 column 9
wfdbdemo at line 8 column 10

I changed manually wfdbloadlib code so that the Java 1.8 version .jar could be used. Unfortunately another error has appeared.

error: [java] java.lang.NullPointerException
error: called from
rdsamp at line 197 column 17
wfdbdemo at line 12 column 11
error: evaluating argument list element number 1
error: called from
rdsamp at line 197 column 17
wfdbdemo at line 12 column 11

I would like to experiment with Octave too, but I was also able to get ahold of Matlab 2017a, which is running fine with the binary zip that I had downloaded from Physionet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants