-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Java JARS for Java 1.8 #129
Comments
Putting this on hold for now, until MATLAB uses Java 1.8 ( the R2016b is still on 1.7). |
Hi Ikaro For when the next MATLAB version comes out, is it done via this:
in the |
Hi, The easiest way is simply running 'make' where the Makefile exists. It will call Eclipse headlessly and compile the jar using the information in the xml file. |
Ikaro, Octave is already using java 1.8. Java 1.8 will be used in the version of MATLAB, according to their site. I am using Octave in Linux, so I am not able to use the toolbox. I need it so much! Please help. |
Hi,
So can you please make sure you running the latest from Github ? If so, what error are you getting ? |
Ikaro, I an running the last version of Physionet's WFDB Matlab website,
which is 0-9-9. I did not get the latest version from GitHub. If this
version is yet in beta stage, then I would ask that you put an observation
on the wfdb website for java 1.8 users to get the newer version from github.
When I get home I will try it. Thanks!
On Apr 21, 2017 11:36, "Ikaro Silva" <[email protected]> wrote:
Hi,
The toolbox has the Java 1.8 dependencies compiled already
(wfdb-app-JVM8-0-9-10.jar). The code has also been update in wfdbloadlib:
%Check if path has not been added yet
if(~isempty(strfind(ml_jar_version,'Java 1.7')))
wfdb_path=[wfdb_path 'wfdb-app-JVM7-0-9-10.jar'];
elseif(~isempty(strfind(ml_jar_version,'Java 1.8')))
wfdb_path=[wfdb_path 'wfdb-app-JVM8-0-9-10.jar'];
else
error(['Cannot load WFDB JAR on unsupported JVM: ' ml_jar_version])
end
So can you please make sure you running the latest from Github ? If so,
what error are you getting ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#129 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AaigvsXDZ1ZtxDehjwtmRKsUZtO4ISc5ks5ryL8GgaJpZM4Jd2uk>
.
|
Ok, I have some news. First of all, I was mistaken, the version in the WFDB website is the same as in Git Hub. But the Java dependencies pŕovided in each zip file are different! The zip in Physionet website had versions 1.6 and 1.7. The zip file in github has versions 1.7 and 1.8. I don't know if you have just updated the (.jar) files, maybe that's the reason. The code that you said that you would update in wfdbloadlib (in github) is still in the old version, so I got the same error as before, even though the (.jar) file has been updated. error: Cannot load WFDB JAR on unsupported JVM: Java 1.8.0_121 I changed manually wfdbloadlib code so that the Java 1.8 version .jar could be used. Unfortunately another error has appeared. error: [java] java.lang.NullPointerException I would like to experiment with Octave too, but I was also able to get ahold of Matlab 2017a, which is running fine with the binary zip that I had downloaded from Physionet. |
No description provided.
The text was updated successfully, but these errors were encountered: