Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding the button shine logic #9477

Open
1 task done
zenseii opened this issue Jan 22, 2025 · 0 comments
Open
1 task done

Expanding the button shine logic #9477

zenseii opened this issue Jan 22, 2025 · 0 comments
Labels
improvement New feature, request or improvement pixel-precision Fine-tuning of UI elements and assets ui UI/GUI related stuff

Comments

@zenseii
Copy link
Collaborator

zenseii commented Jan 22, 2025

Preliminary checks

Describe the problem requiring a solution

The current button shine logic for engine generated buttons is very bare-bones and therefore repetitive and easy to tell apart from the original buttons' shine effect.

Requirements:
The effect needs to be present on the sides and bottom side of buttons too for buttons that are big enough. Also the shine effect shouldn't be exactly the same for every button to keep variety as seen on original buttons.

Describe the possible solution

Expand the function by:

  1. Check the width and height of the button and from this determine if a button should have the effect on the sides and the bottom part and how many shines. The distinction will be between single lined text buttons and multilined ones.
  2. To make the shine different between buttons of the same size, we can look at the button string value and make this value determine where and how many shines are added to the button. This makes the effect consistent for the same text and between loads of the engine.

Additional info

Different types of shines might have to be added as images or functions that can be copied, or generated on the fly.

@zenseii zenseii added improvement New feature, request or improvement ui UI/GUI related stuff labels Jan 22, 2025
@zenseii zenseii added this to the Beyond OG scope milestone Jan 22, 2025
@zenseii zenseii added the pixel-precision Fine-tuning of UI elements and assets label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement pixel-precision Fine-tuning of UI elements and assets ui UI/GUI related stuff
Projects
None yet
Development

No branches or pull requests

1 participant