Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullRequestEvent doesn't contain review_requested action entry #279

Open
tisonkun opened this issue Aug 5, 2022 · 3 comments
Open

PullRequestEvent doesn't contain review_requested action entry #279

tisonkun opened this issue Aug 5, 2022 · 3 comments

Comments

@tisonkun
Copy link

tisonkun commented Aug 5, 2022

https://docs.github.com/en/developers/webhooks-and-events/events/github-event-types describes the PullRequestEvent's actions can be one of: opened, edited, closed, reopened, assigned, unassigned, review_requested, review_request_removed, labeled, unlabeled, and synchronize.

However, when analyzing GHArchive data it gives:

SELECT
    action,
    COUNT(1)
FROM github_events
WHERE event_type = 'PullRequestEvent'
GROUP BY action;

┌─action──────┬───count()─┐
│ opened      │ 226861706 │
│ closed      │ 172356866 │
│ reopened    │   1924348 │
│ labeled     │        24 │
│ synchronize │    453125 │
│ merged      │         4 │
└─────────────┴───────────┘

There're no review_requested or review_requested_removed.

I don't know whether it's no such event from the API or the crawler doesn't handle it.

@tisonkun
Copy link
Author

tisonkun commented Aug 5, 2022

Also labeled and merged data are catched once but later don't occur.

@tisonkun
Copy link
Author

tisonkun commented Aug 5, 2022

Actually, after 2015 there're only events with action 'opened', 'closed', 'reopened'. Others occurred before 2012, and labeled occurred in some days in 2017.

@frank-zsy
Copy link

@tisonkun It is not an issue about GHArchive, actually GitHub webhook events and timeline events are different although they share the same data schema. I think it is maybe for cost concern, labeled, assigned and other actions are not included in timeline events so we will not get the data in GitHub events log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants