Skip to content

Commit 315a7d1

Browse files
authored
Merge pull request #33 from iden3/fix-darwin-gmp-build
Fix darwin gmp build
2 parents 54afaa9 + 4346473 commit 315a7d1

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ git submodule init
9494
git submodule update
9595
./build_gmp.sh android
9696
mkdir build_prover_android && cd build_prover_android
97-
cmake .. -DTARGET_PLATFORM=ANDROID -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../package_android
97+
cmake .. -DTARGET_PLATFORM=ANDROID -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../package_android -DBUILD_TESTS=OFF
9898
make -j4 && make install
9999
```
100100

build_gmp.sh

+10-2
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,11 @@ build_android()
128128
return 1
129129
fi
130130

131-
export TOOLCHAIN=$ANDROID_NDK/toolchains/llvm/prebuilt/linux-x86_64
131+
if [ "$(uname)" == "Darwin" ]; then
132+
export TOOLCHAIN=$ANDROID_NDK/toolchains/llvm/prebuilt/darwin-x86_64
133+
else
134+
export TOOLCHAIN=$ANDROID_NDK/toolchains/llvm/prebuilt/linux-x86_64
135+
fi
132136

133137
export TARGET=aarch64-linux-android
134138
export API=21
@@ -173,7 +177,11 @@ build_android_x86_64()
173177
return 1
174178
fi
175179

176-
export TOOLCHAIN=$ANDROID_NDK/toolchains/llvm/prebuilt/linux-x86_64
180+
if [ "$(uname)" == "Darwin" ]; then
181+
export TOOLCHAIN=$ANDROID_NDK/toolchains/llvm/prebuilt/darwin-x86_64
182+
else
183+
export TOOLCHAIN=$ANDROID_NDK/toolchains/llvm/prebuilt/linux-x86_64
184+
fi
177185

178186
export TARGET=x86_64-linux-android
179187
export API=21

cmake/platform.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ else()
7979

8080
endif()
8181

82-
if (CMAKE_HOST_SYSTEM_NAME MATCHES "Darwin")
82+
if (CMAKE_HOST_SYSTEM_NAME MATCHES "Darwin" AND NOT TARGET_PLATFORM MATCHES "^android(_x86_64)?")
8383
set(GMP_DEFINIONS -D_LONG_LONG_LIMB)
8484
endif()
8585

src/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ endif()
1616

1717
if(USE_ASM AND ARCH MATCHES "x86_64")
1818

19-
if (CMAKE_HOST_SYSTEM_NAME MATCHES "Darwin")
19+
if (CMAKE_HOST_SYSTEM_NAME MATCHES "Darwin" AND NOT TARGET_PLATFORM MATCHES "^android(_x86_64)?")
2020
set(NASM_FLAGS -fmacho64 --prefix _)
2121
else()
2222
set(NASM_FLAGS -felf64 -DPIC)

0 commit comments

Comments
 (0)