Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto EEID Assignment in FlexiblePatternGenerator #29530

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

miaoyinb
Copy link
Contributor

closes #29529

@moosebuild
Copy link
Contributor

moosebuild commented Dec 12, 2024

Job Documentation, step Docs: sync website on cd8f050 wanted to post the following:

View the site here

This comment will be updated on new commits.

@miaoyinb miaoyinb marked this pull request as ready for review December 16, 2024 15:19
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@miaoyinb
Copy link
Contributor Author

Thanks for the review. I modified the test to have two input meshes.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on cd8f050 wanted to post the following:

Framework coverage

cf0cd9 #29530 cd8f05
Total Total +/- New
Rate 85.19% 85.19% +0.00% -
Hits 108318 108319 +1 0
Misses 18832 18831 -1 0

Diff coverage report

Full coverage report

Modules coverage

Reactor

cf0cd9 #29530 cd8f05
Total Total +/- New
Rate 93.64% 93.67% +0.03% 100.00%
Hits 7608 7645 +37 37
Misses 517 517 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud GiudGiud merged commit 70a6fb6 into idaholab:next Dec 16, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Auto EEID Assignment in FlexiblePatternGenerator
3 participants