Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize / clean up interface kernels to be called only on one side of a sideset #29235

Open
GiudGiud opened this issue Dec 4, 2024 · 0 comments
Labels
C: Framework T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Dec 4, 2024

Motivation

to solve #15024, interface kernels are called on both sides of every interface.
The execution ok the ik is prevent when the wrong side is detected.

related to libMesh/libmesh#2494 which would reduce the number of occurences of inconsistently oriented sidesets

Design

Using a future Diagnostics system, make sure sidesets are consistently and well oriented for the IKs first
Error if not

When consistently oriented, we should be able to loop on sides only once, on the right side

Impact

Minor performance improvement expected, only for simulations relying on interface kernels. Interface kernels are executed much less than anything volumetric, so this wont make anything much faster
Minor code cleanup

@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

1 participant