Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

The Online Converter messes up object initializers #514

Open
beppe9000 opened this issue Feb 9, 2016 · 11 comments
Open

The Online Converter messes up object initializers #514

beppe9000 opened this issue Feb 9, 2016 · 11 comments

Comments

@beppe9000
Copy link

When converting C# to Vb.Net using the Online Converter i found two issues, #513 is the first, and this is the second.

Code with object initializers like this

StudentName student2 = new StudentName
        {
            FirstName = "Craig",
            LastName = "Playstead",
        };

is wrongly translated to this (notice the "Key " parts)

Dim student2 As New StudentName() With { _
    Key .FirstName = "Craig", _
    Key .LastName = "Playstead" _
}

instead of this

Dim student2 As New StudentName() With { _
    .FirstName = "Craig", _
    .LastName = "Playstead" _
}
@christophwille
Copy link
Member

The code converter feature is part of SharpDevelop 4.x, which doesn't use NRefactory 5. So the bugs would need to go to SharpDevelop for the old branches (however, it is unlikely that this would be fixed for 4.x)

@beppe9000
Copy link
Author

Was the feature dropped?

@christophwille
Copy link
Member

SD5 does support only C# so far, so it simply isn't there for the obvious reason of no VB support.

@beppe9000
Copy link
Author

I do not understand: has it been rewritten from scratch?

@christophwille
Copy link
Member

NR5 is a complete rewrite, yes

@beppe9000
Copy link
Author

Couldnt'y the old vb part be used as a dependency meanwhile? Or is it completely incompatible?

@christophwille
Copy link
Member

Totally different architecture and design

@beppe9000
Copy link
Author

Oh, I see.. Do you happen to know when (1month, 6 moths, 1 year, forever?) vb support will added?

@dgrunwald
Copy link
Member

We don't plan to add VB support.

NRefactory at this point is mostly dead -- we don't plan to add any new features, not even C# 6 support. Use Microsoft's Roslyn instead. It shouldn't be hard to write a code converter based on Roslyn, though I'm not aware of any such project.

@luca-saggese
Copy link

But what happened to NRefactory Roslyn's branch?
i was working on the VB plugin, but i see is now completed out of scope..

Will sharpdevelop use another plugin for syntax highlight / code completion other than nrefactory?

@dgrunwald
Copy link
Member

The NRefactory Roslyn branch only ever contained refactorings ported to Roslyn. Those were moved to the RefactoringEssentials repository.

Pretty much everything else in NRefactory duplicates Roslyn, so there isn't really a point to having NRefactory anymore. MonoDevelop is moving to Roslyn instead. SharpDevelop doesn't have the manpower to move anywhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants