Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with icat.lucene upgrades #267

Open
patrick-austin opened this issue Jan 28, 2022 · 2 comments · May be fixed by #298
Open

Compatibility with icat.lucene upgrades #267

patrick-austin opened this issue Jan 28, 2022 · 2 comments · May be fixed by #298
Assignees
@patrick-austin
Labels
enhancement in progress

Comments

@patrick-austin
Copy link
Contributor

Description:
In the process of making changes to icat.lucene to improve search functionality, the interface in LuceneAPI, LuceneManager etc. will become incompatible. For now these changes are not finalised, but to test them out as part of the full stack need to make the changes to icat.server.

For detail, see icatproject/icat.lucene#18 which also links to sub-issues.
@patrick-austin patrick-austin self-assigned this Jan 28, 2022
@RKrahl
Copy link
Member

RKrahl commented Jan 28, 2022

Will these changes be compatible for clients? E.g. will the exposed ICAT API calls for searching or for interacting with the lucene db change?

@patrick-austin
Copy link
Contributor Author

Will these changes be compatible for clients? E.g. will the exposed ICAT API calls for searching or for interacting with the lucene db change?

Currently neither of those would be affected by the changes, at the moment it's things like classes being renamed in more recent versions of Lucene (which are needed for some functionality).

Going forward there might be changes such as allowing different entities or fields to be searched with Lucene (as currently we only search on Investigations, Datasets/files with Samples/Parameters). But at this stage it's somewhat exploratory to see how additional functionality might be implemented with Lucene.

patrick-austin added a commit that referenced this issue Mar 24, 2022
@patrick-austin
Implement Elasticsearch Java client functions #267
44a9d80
patrick-austin added a commit that referenced this issue Mar 24, 2022
@patrick-austin
Enable field sorting for name and date fields #267
a22fe36
patrick-austin added a commit that referenced this issue Mar 31, 2022
@patrick-austin
Replace abstract methods in SearchApi #267
bfb7d7b
patrick-austin added a commit that referenced this issue Mar 31, 2022
@patrick-austin
Add endpoint allowing fields and searchAfter #267
07a42a3
patrick-austin added a commit that referenced this issue Apr 4, 2022
@patrick-austin
Add asserts to Lucene modify test #267
64d1af5
patrick-austin added a commit that referenced this issue Apr 6, 2022
@patrick-austin
Integration tests and fixes #267
ba32387
patrick-austin added a commit that referenced this issue Apr 11, 2022
@patrick-austin
Text fields and related entities #267
3c0d3bc
patrick-austin added a commit that referenced this issue Apr 19, 2022
@patrick-austin
Enable Lucene facets #267
7efdc36
patrick-austin added a commit that referenced this issue Apr 20, 2022
@patrick-austin
Basic unit conversion tests #267
5e93b3d
patrick-austin added a commit that referenced this issue Apr 27, 2022
@patrick-austin
Add support for Opensearch requests #267
7eeb840
patrick-austin added a commit that referenced this issue Apr 29, 2022
@patrick-austin
Integration test fixes and text analysis #267
9450c4b
patrick-austin added a commit that referenced this issue Apr 29, 2022
@patrick-austin
Refactor SearchApi functions for clarity #267
901e3ad
patrick-austin added a commit that referenced this issue May 6, 2022
@patrick-austin
SearchApi and unit conversion refactors #267
3aa8d3a
patrick-austin added a commit that referenced this issue Jun 8, 2022
@patrick-austin
Add fields needed for DGS component #267
eb26a87
patrick-austin added a commit that referenced this issue Jun 14, 2022
@patrick-austin
Update Search tests with Instruments #267
b228aa3
patrick-austin added a commit that referenced this issue Jun 16, 2022
@patrick-austin
Sparse string faceting fix #267
87ee1a3
patrick-austin added a commit that referenced this issue Jun 16, 2022
@patrick-austin
Filters and aborted search support #267
50d2dab
patrick-austin added a commit that referenced this issue Jun 17, 2022
@patrick-austin
Return correct Json for aborted searches #267
cbf2cf4
patrick-austin added a commit that referenced this issue Jun 17, 2022
@patrick-austin
Enable mutlivalue string facets #267
5af7b18
patrick-austin added a commit that referenced this issue Jul 7, 2022
@patrick-austin
Refactors and Javadoc comments #267
134303c
patrick-austin added a commit that referenced this issue Jul 13, 2022
@patrick-austin
Support searches on sample name #267
b257f81
patrick-austin added a commit that referenced this issue Jul 26, 2022
@patrick-austin
SampleParameter, fileCount, value in range #267
c7d2a7a
patrick-austin added a commit that referenced this issue Aug 2, 2022
@patrick-austin
Add utility to population and timed aggregation #267
c141e42
patrick-austin added a commit that referenced this issue Aug 3, 2022
@patrick-austin
Improve timed file aggregation #267
42bcef0
patrick-austin added a commit that referenced this issue Aug 5, 2022
@patrick-austin
Improved timeout and search syntax errors #267
e7a322c
patrick-austin added a commit that referenced this issue Aug 5, 2022
@patrick-austin
search.maxSearchTimeSeconds added to run.properties #267
1f59002
patrick-austin added a commit that referenced this issue Aug 9, 2022
@patrick-austin
Range check for lock #267
fbc9b2a
patrick-austin added a commit that referenced this issue Aug 18, 2022
@patrick-austin
Remove OS/ES support #267
152d548
This was referenced Aug 19, 2022
Draft
Draft
patrick-austin added a commit that referenced this issue Sep 13, 2022
@patrick-austin
Add support for faceting DatasetTechnique #267
37668c5
patrick-austin added a commit that referenced this issue Sep 16, 2022
@patrick-austin
Add deprecation warnings #267
de8fd2d
patrick-austin added a commit that referenced this issue Oct 14, 2022
@patrick-austin
Refactors in EntityBeanManager and SearchManager #267
60f30a6
patrick-austin added a commit that referenced this issue Oct 14, 2022
@patrick-austin
Review changes, Opensearch refactors and fixes #267
de47467
patrick-austin added a commit that referenced this issue Oct 21, 2022
@patrick-austin
Update OpensearchQuery docstrings after refactor #267
e91214f
patrick-austin added a commit that referenced this issue Jul 3, 2023
@patrick-austin
Remove placeholder values for size and count #267
8abef9a
patrick-austin added a commit that referenced this issue Sep 28, 2023
@patrick-austin
Index id as long instead of String #267
bfcb7b0
patrick-austin added a commit that referenced this issue Sep 28, 2023
@patrick-austin
Special handling for InvestigationInstrument facets #267
f8a977b
patrick-austin added a commit that referenced this issue Oct 5, 2023
@patrick-austin
Revert accidental deletion of Facility setters #267
3dac87b
patrick-austin added a commit that referenced this issue Oct 6, 2023
@patrick-austin
Add investigation null check in Sample.getDoc #267
efd1261
patrick-austin added a commit that referenced this issue Oct 10, 2023
@patrick-austin
Tests for Investigation Sample filtering #267
f2e59e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick-austin patrick-austin

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search Improvements (OS/ES support) icatproject/icat.server
2 participants
@RKrahl @patrick-austin