-
Notifications
You must be signed in to change notification settings - Fork 5
Search Improvements (OS/ES support) #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/icatproject/icat.server into 277_filterReadAccess_improvement
VKTB
approved these changes
Oct 21, 2022
Co-authored-by: Viktor Bozhinov <[email protected]>
6c27f0d
to
200cb3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers a variety of improvements to free text search functionality.
Closes #267
Changes to functionality
Investigation
/Dataset
/Datafile
), we also use the public steps/tables to safely return nested information (such as aDatafileParameter
without additional time spent authorising)Changes to code
getDoc
either added or expanded, alongside the addition ofgetDocumentFields
which enforces that the search component does not return metadata that isn't allowed by the ICAT public steps/tablesICATRest
and added new endpointssearch/documents
andfacet/documents
EntityBeanManager
to support new search callsGateKeeper
to allow the publicly allowed search fields to be marked as stale and updated as public steps/tables are updatedPropertyHandler
to support differentSearchEngine
s as config options as well as other new config parametersLuceneManager
replaced with genericSearchManager
which interacts with the search engine via an instance ofSearchApi
SearchApi
, and abstract class for interfacing with search engine implementationsLuceneApi
modified extensively, and now extendsSearchApi
OpensearchApi
which extendsSearchApi
and supports either Opensearch or Elasticsearch clusters by building generic JSON. Also has some static functionality refactored into supporting classes:OpensearchQueryBuilder
OpensearchScriptBuilder
FacetDimension
andFacetLabel
to represent facets of results, and replacingLuceneSearchResult
withSearchResult
which has facet supportluceneAbc
tosearchAbc
to reflect what is or isn't specific to theicat.lucene
search engineInterdependencies on other components