Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential to block when parsing huge string with lots of escaped characters #18

Open
toniuyt123 opened this issue Sep 12, 2019 · 1 comment

Comments

@toniuyt123
Copy link

toniuyt123 commented Sep 12, 2019

The way string normalization is done is blocking and tough it would normally be fast, in case of an enormous string with many escaped characters the operation will be very slow and blocking. The easiest way to achieve this is by stringifying a json string and then parsing it back.
I'd suggest making it into a generator function so that it can yield and also looking for a way of speeding it up.

@gireeshpunathil
Copy link
Member

@toniuyt123 - thanks for raising this, and for the proposal! definitely looks promising; will make a try with that approach. Meanwhile, please feel free to contribute, if you are willing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants