Added validation for non-empty 'name' option

Author: mikadamczyk

src/lib/Twig/Components/AbstractChoiceInput.php

@@ -44,7 +44,10 @@ public function validate(array $props): array
         $resolver
             ->define('name')
             ->required()
-            ->allowedTypes('string');
+            ->allowedTypes('string')
+            ->allowedValues(static function (string $value): bool {
+                return trim($value) !== '';
+            });
         $resolver
             ->define('checked')
             ->allowedTypes('bool')

tests/integration/Twig/Components/Checkbox/FieldTest.php

@@ -101,6 +101,15 @@ public function testInvalidIndeterminateTypeCausesResolverErrorOnMount(): void
         ]));
     }
 
+    public function testEmptyNameCausesResolverErrorOnMount(): void
+    {
+        $this->expectException(InvalidOptionsException::class);
+
+        $this->mountTwigComponent(Field::class, $this->baseProps([
+            'name' => '',
+        ]));
+    }
+
     public function testEmptyIdCausesResolverErrorOnMount(): void
     {
         $this->expectException(InvalidOptionsException::class);

tests/integration/Twig/Components/Checkbox/InputTest.php

@@ -104,6 +104,17 @@ public function testInvalidIndeterminateTypeCausesResolverErrorOnMount(): void
         ]);
     }
 
+    public function testEmptyNameCausesResolverErrorOnMount(): void
+    {
+        $this->expectException(InvalidOptionsException::class);
+
+        $this->mountTwigComponent(Input::class, [
+            'id' => 'agree',
+            'name' => '',
+            'value' => 'yes',
+        ]);
+    }
+
     public function testMissingRequiredOptionsCauseResolverErrorOnMount(): void
     {
         $this->expectException(MissingOptionsException::class);

tests/integration/Twig/Components/RadioButton/FieldTest.php

@@ -81,6 +81,18 @@ public function testInputBooleanAttributesAndClassesPassThrough(): void
         self::assertNotNull($input->attr('required'), 'Required should render native "required" attribute.');
     }
 
+    public function testEmptyNameCausesResolverErrorOnMount(): void
+    {
+        $this->expectException(InvalidOptionsException::class);
+
+        $this->mountTwigComponent(
+            Field::class,
+            $this->baseProps([
+                'name' => '',
+            ])
+        );
+    }
+
     public function testEmptyIdCausesResolverErrorOnMount(): void
     {
         $this->expectException(InvalidOptionsException::class);
@@ -92,6 +104,7 @@ public function testEmptyIdCausesResolverErrorOnMount(): void
             ])
         );
     }
+
     public function testInvalidAttributesTypeCausesResolverErrorOnMount(): void
     {
         $this->expectException(InvalidOptionsException::class);

tests/integration/Twig/Components/RadioButton/InputTest.php

@@ -112,6 +112,16 @@ public function testSizeVariantSmallAddsClass(): void
         self::assertStringContainsString('ids-input--small', $this->getClassAttr($input), 'Size "small" should add "ids-input--small" class.');
     }
 
+    public function testEmptyNameCausesResolverErrorOnMount(): void
+    {
+        $this->expectException(InvalidOptionsException::class);
+
+        $this->mountTwigComponent(Input::class, [
+            'name' => '',
+            'value' => 'A',
+        ]);
+    }
+
     public function testInvalidDisabledTypeCausesResolverErrorOnMount(): void
     {
         $this->expectException(InvalidOptionsException::class);