Enhanced ChoiceInputLabel validation to disallow empty 'for' values

Author: mikadamczyk

src/lib/Twig/Components/ChoiceInputLabel.php

@@ -36,7 +36,10 @@ public function validate(array $props): array
         $resolver
             ->define('for')
             ->required()
-            ->allowedTypes('string');
+            ->allowedTypes('string')
+            ->allowedValues(static function (string $value): bool {
+                return trim($value) !== '';
+            });
 
         return $resolver->resolve($props) + $props;
     }

tests/integration/Twig/Components/ChoiceInputLabelTest.php

@@ -71,6 +71,13 @@ public function testAttributesMergeClassAndData(): void
         self::assertSame('custom', $label->attr('data-custom'), 'Custom data attribute should be rendered on the label.');
     }
 
+    public function testEmptyForCausesResolverErrorOnMount(): void
+    {
+        $this->expectException(InvalidOptionsException::class);
+
+        $this->mountTwigComponent(ChoiceInputLabel::class, ['for' => '', 'content' => 'x']);
+    }
+
     public function testInvalidForTypeCausesResolverErrorOnMount(): void
     {
         $this->expectException(InvalidOptionsException::class);