Skip to content

IBX-10575: Fixed dropdown alignment #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

IBX-10575: Fixed dropdown alignment #1750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a50ca6
IBX-10575: Fixed dropdown alignment
alekmick Oct 20, 2025
b6cc0bc
Fixed readability
alekmick Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/bundle/Resources/public/scss/_dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,15 @@
padding-top: 0;
padding-bottom: 0;
margin-right: calculateRem(8px);
display: inline-block;
max-width: calculateRem(380px);
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
transition: all $ibexa-admin-transition-duration $ibexa-admin-transition;

&-label {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use it like that. It is less readable.
Please do &__selected-item-label {} outside of the &__selected-item

white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

&--has-icon {
border-radius: 0;
}
Expand Down
17 changes: 11 additions & 6 deletions src/bundle/Resources/views/themes/admin/ui/component/dropdown/dropdown.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
<div class="ibexa-dropdown__wrapper">
{% set placeholder_list_item %}
<li class="ibexa-dropdown__selected-item ibexa-dropdown__selected-item--predefined ibexa-dropdown__selected-placeholder">
{{ 'dropdown.placeholder.empty'|trans|desc("No options available") }}
<span class="ibexa-dropdown__selected-item-label">
{{ 'dropdown.placeholder.empty'|trans|desc("No options available") }}
</span
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</span
</span>

</li>
{% endset %}
<ul
Expand Down Expand Up @@ -111,11 +113,14 @@
class="ibexa-dropdown__selected-item ibexa-dropdown__selected-item--predefined ibexa-dropdown__selected-placeholder"
{% if value is empty %}hidden{% endif %}
>
{% if placeholder is defined and placeholder is not none %}
{{ _self.get_translated_label(placeholder, translation_domain )}}
{% else %}
{{ 'dropdown.placeholder'|trans|desc("Choose an option") }}
{% endif %}
<span class="ibexa-dropdown__selected-item-label">
{% if placeholder is defined and placeholder is not none %}
{{ _self.get_translated_label(placeholder, translation_domain )}}
{% else %}
{{ 'dropdown.placeholder'|trans|desc("Choose an option") }}
{% endif %}
</span>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

</li>
{% endif %}
{% endif %}
Expand Down
4 changes: 3 additions & 1 deletion ...undle/Resources/views/themes/admin/ui/component/dropdown/dropdown_selected_item.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
{{ include('@ibexadesign/ui/component/dropdown/dropdown_selected_item_icon.html.twig', { icon }) }}
{% endif %}
</span>
{{ label }}
<span class="ibexa-dropdown__selected-item-label">
{{ label }}
</span>
<span class="ibexa-dropdown__remove-selection"></span>
</li>
2 changes: 1 addition & 1 deletion src/bundle/ui-dev/src/modules/common/dropdown/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const Dropdown = ({
const renderSelectedMultipleItem = (item) => {
return (
<li key={item.value} className="ibexa-dropdown__selected-item">
{item.label}
<span className="ibexa-dropdown__selected-item-label">{item.label}</span>
<span className="ibexa-dropdown__remove-selection" onClick={() => onChange(item.value)} />
</li>
);
Expand Down
Loading