Code cleanup and naming improvments

Author: KamilSznajdrowicz

src/lib/Behat/BrowserContext/UserNotificationContext.php

@@ -85,7 +85,7 @@ public function noNotificationAppearsWithDetails(TableNode $notificationDetails)
     /**
      * @When I open notification menu with description :description
      */
-    public function iOpenNotificationMenuNotification(string $description): void
+    public function iOpenNotificationMenu(string $description): void
     {
         $this->userNotificationPopup->openNotificationMenu($description);
     }
@@ -152,9 +152,9 @@ public function thereIsNoNotificationOnList(string $notificationTitle): void
     }
 
     /**
-     * @When I marked as unread notification with title :notificationTitle
+     * @When I mark notification as unread with title :notificationTitle
      */
-    public function iMarkedNotificationAsUnread(string $notificationTitle): void
+    public function iMarkNotificationAsUnread(string $notificationTitle): void
     {
         $this->notificationsPage->markAsUnread($notificationTitle);
     }
@@ -176,7 +176,7 @@ public function iGoToContent(string $notificationTitle): void
     }
 
     /**
-     * @When I deleted notification with title :notificationTitle
+     * @When I delete notification with title :notificationTitle
      */
     public function iDeleteNotification(string $notificationTitle): void
     {

src/lib/Behat/Page/NotificationsPage.php

@@ -21,8 +21,7 @@ final class NotificationsPage extends Page
 {
     private TableInterface $table;
 
-    /** @var \Ibexa\AdminUi\Behat\Component\Dialog */
-    private $dialog;
+    private Dialog $dialog;
 
     public function __construct(
         Session $session,
@@ -71,13 +70,11 @@ public function deleteNotification(string $notificationTitle): void
         $this->dialog->confirm();
     }
 
-    public function getStatusForNotification(string $notificationStatus): string
+    public function getStatusForNotification(string $notificationTitle): string
     {
-        return $this->getHTMLPage()
-            ->findAll($this->getLocator('tableRow'))
-            ->getByCriterion(new ChildElementTextCriterion($this->getLocator('rowName'), $notificationStatus))
-            ->find($this->getLocator('rowStatus'))
-            ->getText();
+        return $this->getHTMLPage()->findAll($this->getLocator('tableRow'))
+            ->getByCriterion(new ChildElementTextCriterion($this->getLocator('rowName'), $notificationTitle))
+            ->find($this->getLocator('rowStatus'))->getText();
     }
 
     public function verifyIsLoaded(): void