[JMS] Fixed sorting translation extractor (#1749)

* [JMS] Improved SortingTranslationExtractor

* [PHPStan] Removed resolved issues from the baseline

Author: alongosz

phpstan-baseline.neon

@@ -12642,24 +12642,6 @@ parameters:
 			count: 1
 			path: src/lib/Translation/Extractor/PolicyTranslationExtractor.php
 
-		-
-			message: '#^Method Ibexa\\AdminUi\\Translation\\Extractor\\SortingTranslationExtractor\:\:extract\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: src/lib/Translation/Extractor/SortingTranslationExtractor.php
-
-		-
-			message: '#^Property Ibexa\\AdminUi\\Translation\\Extractor\\SortingTranslationExtractor\:\:\$defaultTranslations has no type specified\.$#'
-			identifier: missingType.property
-			count: 1
-			path: src/lib/Translation/Extractor/SortingTranslationExtractor.php
-
-		-
-			message: '#^Property Ibexa\\AdminUi\\Translation\\Extractor\\SortingTranslationExtractor\:\:\$domain has no type specified\.$#'
-			identifier: missingType.property
-			count: 1
-			path: src/lib/Translation/Extractor/SortingTranslationExtractor.php
-
 		-
 			message: '#^Method Ibexa\\AdminUi\\UI\\Action\\FormUiActionMapper\:\:map\(\) has parameter \$form with generic interface Symfony\\Component\\Form\\FormInterface but does not specify its types\: TData$#'
 			identifier: missingType.generics

src/lib/Translation/Extractor/SortingTranslationExtractor.php

@@ -19,7 +19,12 @@
  */
 class SortingTranslationExtractor implements ExtractorInterface
 {
-    private $defaultTranslations = [
+    /**
+     * Default translations for sort fields.
+     *
+     * @var array<int, string>
+     */
+    private array $defaultTranslations = [
         1 => 'Location path',
         2 => 'Publication date',
         3 => 'Modification date',
@@ -31,18 +36,16 @@ class SortingTranslationExtractor implements ExtractorInterface
         9 => 'Content name',
     ];
 
-    private $domain = 'ibexa_content_type';
+    private string $domain = 'ibexa_content_type';
 
-    public function extract()
+    public function extract(): MessageCatalogue
     {
         $catalogue = new MessageCatalogue();
         $locationClass = new \ReflectionClass(Location::class);
 
         $sortConstants = array_filter(
             $locationClass->getConstants(),
-            static function ($value, $key) {
-                return is_scalar($value) && strtolower(substr($key, 0, 11)) === 'sort_field_';
-            },
+            static fn ($value, $key): bool => is_int($value) && str_starts_with(strtolower($key), 'sort_field_'),
             ARRAY_FILTER_USE_BOTH
         );