Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPC Event type is no longer compatible with Electron.IpcMainEvent #7575

Open
GytisCepk opened this issue Jan 20, 2025 · 0 comments
Open

IPC Event type is no longer compatible with Electron.IpcMainEvent #7575

GytisCepk opened this issue Jan 20, 2025 · 0 comments
Labels
electron

Comments

@GytisCepk
Copy link
Contributor

Problem

Recently Electron changed it's IpcMainEvent definition: electron/electron#44651

Now, Electron.IpcMainEvent does not satisfy Event type used by IpcListener. As a result, IpcListener passed to IpcSocket.addListener can't be passed further to Electron.IpcMain.addListener and requires casting to any. This also affects IpcSocketBackend.handle.

As far as I can tell, this does not break any functionality, but it means our IpcListener type is incorrect.

Possible solution

Add new IpcEvent type to replace Event in IpcListener (breaking change).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aruniverse @GytisCepk