Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure and consistency of the base persisters. #52

Open
thorwhalen opened this issue Feb 27, 2020 · 1 comment
Open

Structure and consistency of the base persisters. #52

thorwhalen opened this issue Feb 27, 2020 · 1 comment

Comments

@thorwhalen
Copy link
Member

We need to structure the persisters construction interface more.

Principles:

  • Have at least one common interface that is common to all (I believe this is going to be source as the first argument, and filt or subset, or something like that as a second, and after that they could diverge. They could actually share another common "constructor interface" with a uri containing all, or most of what's needed (most information COULD (not saying it SHOULD) be encoded in a uri.

  • There should be at least one very specific, very low level constructor. One that is specific to the storage system, and in the language of the tool (say sqlalchemy, pymongo, etc.) that we use to talk to it.

Questions arise as to whether the __init__ should be.
Should it be a lower level kind, specific to the context (but with factories or subclasses offering other, usually easier, ways to make persisters)?
Should it be one of the higher level consistent API ones such as the one including a uri?

@thorwhalen
Copy link
Member Author

Some relevant issues:
#5
#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant