Skip to content

​​Feedback on the cluster() function error #1

@huanghe0220

Description

@huanghe0220

Dear developers,

I encountered an issue when using the cluster() function from the ​​RichCluster​​ package. The error occurs in the line:

merged_df <- merged_df %>% filter(Pvalue < min_value)

​​Problem description:​​

  1. ​​Missing 'Pvalue' column error:​​

    Despite my input dataframe containing a "Pvalue" column, the code throws an error: "object 'Pvalue' not found".

  2. Preference for Padj instead of Pvalue:​​

    I intend to filter by the Padj column (corrected p-values) rather than raw Pvalue. However, the current implementation hardcodes Pvalue, limiting flexibility. A parameter to specify the p-value column (e.g., p_column = "Padj") would greatly enhance usability.

  3. Missing dplyr dependency handling:​​

    While ​​RichCluster​​ depends on dplyr, it does not internally load the package with library(dplyr), causing pipeline failures unless users manually load it beforehand. Explicitly importing dplyr functions or adding library(dplyr) to internal code would resolve this.


Best regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions