-
-
Notifications
You must be signed in to change notification settings - Fork 36
memory/shared: add dynamicPointerCast #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
it imploded. |
|
try now |
nope |
|
you didnt rebuild aq xd |
yeah ABI matters it seems ;) disregard the above self inflicted implosions. nested runs, il proceed with a complete rebuild and check live too. |
|
yeah and this leaks gotta fix |
|
I am a bit confused. |
|
Ok as a cpp noop i didnt know that multiple inheritance can actually change the pointer. I now understand |
|
cpp moment |
e039b75 to
117d6fc
Compare
|
Alternative approach. Seems to work. Please test :) |
|
It does seem to work fine. But idk if it is a good idea to have this pointer in SP. If we want this: #93, it would be nice if that would also work for WP's. |
Adds a dynamic cast equivalent for our shared pointers. Tests pass, I hope nothing implodes xD
cc @PaideiaDilemma @gulafaran can yall check I didnt mess something up