fixup: change default filename to "<unknown>" and aother small updates

Signed-off-by: Doru Blânzeanu <[email protected]>

Author: dblnz

src/hyperlight_host/src/hypervisor/crashdump.rs

@@ -84,16 +84,15 @@ impl GuestView {
             })
             .collect();
 
-        // The filename and command line are set to null-terminated strings
         let filename = ctx
             .filename
-            .clone()
-            .map_or_else(|| "\0".to_string(), |s| format!("{}\0", s));
+            .as_ref()
+            .map_or_else(|| c"<unknown>".to_string(), |s| format!(c"{}", s));
 
         let cmd = ctx
             .binary
-            .clone()
-            .map_or_else(|| "\0".to_string(), |s| format!("{}\0", s));
+            .as_ref()
+            .map_or_else(|| c"<unknown>".to_string(), |s| format!(c"{}", s));
 
         // The xsave state is checked as it can be empty
         let mut components = vec![];

src/hyperlight_host/src/sandbox/uninitialized.rs

@@ -149,8 +149,7 @@ impl UninitializedSandbox {
             GuestBinary::FilePath(binary_path) => {
                 let path = Path::new(&binary_path)
                     .canonicalize()
-                    .map_err(|e| new_error!("GuestBinary not found: '{}': {}", binary_path, e))?;
-                let path = path
+                    .map_err(|e| new_error!("GuestBinary not found: '{}': {}", binary_path, e))?
                     .into_os_string()
                     .into_string()
                     .map_err(|e| new_error!("Error converting OsString to String: {:?}", e))?;