Skip to content

Commit b4c260f

Browse files
committed
Remove mshv2 option
Signed-off-by: Doru Blânzeanu <[email protected]>
1 parent 49acebf commit b4c260f

File tree

4 files changed

+11
-38
lines changed

4 files changed

+11
-38
lines changed

.github/workflows/Benchmarks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
strategy:
2626
fail-fast: true
2727
matrix:
28-
hypervisor: [hyperv, mshv, mshv3, kvm] # hyperv is windows, mshv and kvm are linux
28+
hypervisor: [hyperv, mshv3, kvm] # hyperv is windows, mshv and kvm are linux
2929
cpu: [amd, intel]
3030
config: [release] # don't want to benchmark debug-builds
3131

@@ -71,7 +71,7 @@ jobs:
7171
# the component model benchmark depends on the wasm wit component
7272
just ensure-tools
7373
just compile-wit
74-
just bench-ci dev release ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
74+
just bench-ci dev release
7575
working-directory: ./src/hyperlight_wasm
7676

7777
- name: Upload Benchmarks

.github/workflows/dep_rust.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
strategy:
3838
fail-fast: true
3939
matrix:
40-
hypervisor: [hyperv, mshv, mshv3, kvm] # hyperv is windows, mshv and kvm are linux
40+
hypervisor: [hyperv, mshv3, kvm] # hyperv is windows, mshv and kvm are linux
4141
cpu: [amd, intel]
4242
config: [debug, release]
4343

@@ -92,15 +92,15 @@ jobs:
9292
run: just clippy ${{ matrix.config }}
9393

9494
- name: Build
95-
run: just build ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
95+
run: just build ${{ matrix.config }}
9696
working-directory: ./src/hyperlight_wasm
9797

9898
- name: Build Rust Wasm examples
9999
run: just build-rust-wasm-examples ${{ matrix.config }}
100100
working-directory: ./src/hyperlight_wasm
101101

102102
- name: Test
103-
run: just test ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
103+
run: just test ${{ matrix.config }}
104104
working-directory: ./src/hyperlight_wasm
105105

106106
- name: Install github-cli (Windows)
@@ -118,14 +118,14 @@ jobs:
118118
shell: pwsh
119119

120120
- name: Test Examples
121-
run: just examples-ci ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
121+
run: just examples-ci ${{ matrix.config }}
122122
working-directory: ./src/hyperlight_wasm
123123
env:
124124
# required for gh cli when downloading
125125
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
126126

127127
- name: Test Component Model Examples
128-
run: just examples-components ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
128+
run: just examples-components ${{ matrix.config }}
129129
working-directory: ./src/hyperlight_wasm
130130

131131
### Benchmarks ###
@@ -141,6 +141,6 @@ jobs:
141141

142142
- name: Run benchmarks
143143
run: |
144-
just bench-ci dev ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
144+
just bench-ci dev ${{ matrix.config }}
145145
working-directory: ./src/hyperlight_wasm
146146
if: ${{ matrix.config == 'release' }}

Cargo.lock

Lines changed: 3 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/hyperlight_wasm/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ print_debug = ["hyperlight-host/print_debug"]
8989
crashdump = ["hyperlight-host/crashdump"]
9090
gdb = ["hyperlight-host/gdb"]
9191
kvm = ["hyperlight-host/kvm"]
92-
mshv2 = ["hyperlight-host/mshv2"]
9392
mshv3 = ["hyperlight-host/mshv3"]
9493

9594
[[bench]]

0 commit comments

Comments
 (0)