From dc0ae7b424057ac98a6d70654cd3e03cd3979e7a Mon Sep 17 00:00:00 2001 From: Yorke Rhodes Date: Tue, 17 Dec 2024 16:10:29 -0500 Subject: [PATCH 1/2] Use implementation instead of admin slot for isProxy --- typescript/sdk/src/deploy/proxy.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/typescript/sdk/src/deploy/proxy.ts b/typescript/sdk/src/deploy/proxy.ts index 8749e433a9..7d0763010b 100644 --- a/typescript/sdk/src/deploy/proxy.ts +++ b/typescript/sdk/src/deploy/proxy.ts @@ -69,8 +69,8 @@ export async function isProxy( provider: ethers.providers.Provider, proxy: Address, ): Promise { - const admin = await proxyAdmin(provider, proxy); - return !eqAddress(admin, ethers.constants.AddressZero); + const implementation = await proxyImplementation(provider, proxy); + return !eqAddress(implementation, ethers.constants.AddressZero); } export function proxyAdminUpdateTxs( From b50d7668b1eb69f2437c08c3e6e78030500294b3 Mon Sep 17 00:00:00 2001 From: Yorke Rhodes Date: Wed, 18 Dec 2024 11:32:07 -0500 Subject: [PATCH 2/2] Create swift-tips-know.md --- .changeset/swift-tips-know.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/swift-tips-know.md diff --git a/.changeset/swift-tips-know.md b/.changeset/swift-tips-know.md new file mode 100644 index 0000000000..1d82d29154 --- /dev/null +++ b/.changeset/swift-tips-know.md @@ -0,0 +1,5 @@ +--- +"@hyperlane-xyz/sdk": patch +--- + +Use implementation instead of admin slot for isProxy