Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeList.txt assumes gcc is /usr/bin/g++ and clang is /usr/bin/clang++ #21

Open
mpmilano opened this issue Feb 14, 2020 · 0 comments
Open

Comments

@mpmilano
Copy link
Member

It looks like the project's root CMakeLists.txt makes assumptions about where clang and GCC are installed which doesn't match all configurations / distributions. In particular, I'm referring to the conditionals which guard appending "-pthread" (and other flags) to the CMAKE_CXX_FLAGS_COMMON variable. The fix is likely as simple as changing the conditional guard by replacing instances of ${CMAKE_CXX_COMPILER} STREQUAL "/usr/bin/clang++" with ${CMAKE_CXX_COMPILER_ID} MATCHES "(C|c?)lang" (and similar for GCC).

The valid values of CMAKE_CXX_COMPILER_ID can be found here

zhipeng-jia pushed a commit to zhipeng-jia/anna that referenced this issue Sep 1, 2021
* Renames droplet to cloudburst

* Adds new Python dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant