Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entity metadata e2e tests into a unique file #7615

Closed
mfacar opened this issue Jan 28, 2025 · 1 comment · Fixed by #7616
Closed

Move entity metadata e2e tests into a unique file #7615

mfacar opened this issue Jan 28, 2025 · 1 comment · Fixed by #7616
Assignees

Comments

@mfacar
Copy link
Collaborator

mfacar commented Jan 28, 2025

One of the tests of e2e/suite1/metadataprops.test.ts was ignored by #7610 given it was failing consistently. This evidenced that there are three test suites testing the same part of the application: e2e/suite1/metadataprops.test.ts, cypress/e2e/media-metadata.cy.ts, cypress/e2e/entity.cy.ts.

These tests must be moved into a unique test file avoiding duplication of steps and keeping all the currently tested scenarios.

@mfacar mfacar self-assigned this Jan 28, 2025
@mfacar mfacar linked a pull request Jan 28, 2025 that will close this issue
@mfacar mfacar mentioned this issue Feb 11, 2025
7 tasks
@mfacar
Copy link
Collaborator Author

mfacar commented Feb 12, 2025

Changes include:

  • deletion of e2e/regression_suites/entities.test.ts
  • deletion of e2e/suite1/metadataprops.test.ts
  • deletion of cypress/e2e/media-metadata.cy.ts
  • test of deleted files were merged in cypress/e2e/entity.cy.ts
  • cypress/e2e/main-document-and-references.cy.ts has part of the previous content of cypress/e2e/references.cy.ts and cypress/e2e/entity.cy.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant