Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheriting select properties does not bring translated thesauri values #7259

Open
hyebin-bina opened this issue Sep 23, 2024 · 4 comments · May be fixed by #7536
Open

Inheriting select properties does not bring translated thesauri values #7259

hyebin-bina opened this issue Sep 23, 2024 · 4 comments · May be fixed by #7536

Comments

@hyebin-bina
Copy link

hyebin-bina commented Sep 23, 2024

Describe the bug
When users inherit a select property from another template, even when relevant thesaurus is fully translated, translated values do not come through.

To Reproduce
Steps to reproduce the behavior:

  1. Create template A with a select property.

  2. Translate thesaurus values attached to the select property in another language.
    Screenshot 2024-09-23 at 9 34 59 PM
    Screenshot 2024-09-23 at 9 34 08 PM

  3. Create and populate an entity in template A.

  4. Create template B with a relationship property, inheriting the single property of template A created in step 1. Check "use as filter" for better visibility.

  5. Go to the library, create an entity in template B, inheriting select property of the entity created in step 3.

  6. Switch the interface in another language.

  7. Check the inherited values on the side panel and confirm the inherited values are displayed in English in other language interfaces, even after translating the thesauri values.
    Screenshot 2024-09-23 at 9 33 09 PM

Expected behavior
When inheriting select properties, corresponding thesauri's translations should be inherited.

cc: @LuGomezV @salvalacruz

@txau
Copy link
Collaborator

txau commented Sep 23, 2024

This may be the same or related to:

#7184
#7183

@RafaPolit
Copy link
Member

The above report and ways to reproduce is 100% correct.

After research, the bug is NOT on the denormalized data, which is working as expected. The problem is just on the filters for inherited properties. "Root selects" do respect the translation, but this is apparently being done in the Front End, as the backend is sending always the base property name. So I believe this is a frontend issue. cc @konzz

@aphilop
Copy link

aphilop commented Dec 4, 2024

@txau I assume you closed that accidentally.
This is not done and the frontend committed to fix this in this sprint.
I reopen this.

@aphilop aphilop reopened this Dec 4, 2024
@txau
Copy link
Collaborator

txau commented Dec 4, 2024

@aphilop I think that was an accidental drag and drop while using GitHub on mobile. It is pretty glitchy. Thanks for spotting that

@konzz konzz assigned konzz and josh-huridocs and unassigned konzz Dec 4, 2024
@josh-huridocs josh-huridocs linked a pull request Dec 11, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants