feat: NavigationMenu.Item - openOnHover prop
#1223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntabyte
added
the
publish:preview
🦋 Changeset detectedLatest commit: a6581eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
I think it solves my usecase, in combination with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new prop to
NavigationMenu.Item,openOnHover, which defaults totrue(behavior today), to enable users to prevent opening the item'sNavigationMenu.Contenton hover.To provide more flexibility, we added it to the individual items instead of the
NavigationMenu.Root.When
openOnHover={false}, the menu will no longer close when the pointer leaves the trigger/content and will instead expect a more explicit close event, such as pointer down outside, escape key down, or focus outside.Closes #1222