Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Dialog.Trigger has no disabled attribute #1056

Closed
esposm03 opened this issue Jan 18, 2025 · 0 comments
Closed

next: Dialog.Trigger has no disabled attribute #1056

esposm03 opened this issue Jan 18, 2025 · 0 comments

Comments

@esposm03
Copy link

esposm03 commented Jan 18, 2025

Describe the bug

In bits-ui latest, one could use the disabled attribute on a Dialog.Trigger, and it would get propagated to the underlying button element. In bits-ui next, this appears to not be the case anymore.

Attached is a reproduction url. There, you can see a disabled Trigger, and a global style that should make all disabled elements red; that is, however, not the case. Additionally, the onclick handler for the button is triggered when clicking on it.
If instead you try going to package.json, changing the version of bits-ui from ^1.0.0-next.77 to ^0.22.0 and restarting the vite server (after running npm install), you'll see that the button does become red, and clicking on it has no effect.

Reproduction

https://stackblitz.com/edit/vitejs-vite-gdsn6efr?file=src%2FApp.svelte

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    bits-ui: ^1.0.0-next.77 => 1.0.0-next.77 
    svelte: ^5.16.5 => 5.19.0

Severity

blocking an upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants