Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling Sheet.Trigger not behaving consistently with Button (Svelte5/bits-ui@next) #1050

Closed
perezd opened this issue Jan 16, 2025 · 2 comments

Comments

@perezd
Copy link

perezd commented Jan 16, 2025

Describe the bug

I'm observing that when setting the disabled prop on Sheet.Trigger, the underlying element's disabled attribute is not specified as expected, which results in styling that selects for disabled: not correctly applied. However, the trigger itself is properly disabled, meaning the behavior does not fire. This results in a visual bug, even though the behavior works as intended.

Reproduction

https://stackblitz.com/edit/github-n64xaskp?file=repro%2Fsrc%2Froutes%2F%2Bpage.svelte

Logs

No response

System Info

System:
    OS: macOS 15.1.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1000.88 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 23.4.0 - /opt/homebrew/bin/node
    npm: 10.9.2 - /opt/homebrew/bin/npm
    pnpm: 8.14.0 - /opt/homebrew/bin/pnpm
    bun: 1.1.42 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: 131.1.73.105
    Safari: 18.1.1
  npmPackages:
    @sveltejs/kit: ^2.8.1 => 2.8.1 
    bits-ui: ^1.0.0-next.77 => 1.0.0-next.77 
    svelte: ^5.16.5 => 5.16.5

Severity

annoyance

@perezd
Copy link
Author

perezd commented Jan 16, 2025

Note, my repro uses shadcn-svelte (next), but internally it's lightly wrapping bits-ui for this sheet behavior.

@ieedan
Copy link

ieedan commented Jan 17, 2025

Opening a PR for this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants