-
Notifications
You must be signed in to change notification settings - Fork 140
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
On the latest 2.7.0 and development 2.8.0, market_making.pmm_simple has extra fields when the PMM simple controller-config created:
position_rebalance_threshold_pct: '0.05'
skip_rebalance: false
However this is not the case for controller-configs from dashboard/hummingbot-api, the controlelr config created does not include these fields which I observed automatically enabled the default values causing order submission issue
Sample config generated from hummingbot-api
buy_amounts_pct:
- 1.0
buy_spreads:
- 0.001
candles_config: []
connector_name: binance
controller_name: pmm_simple
controller_type: market_making
cooldown_time: 60.0
executor_refresh_time: 180.0
id: sequence-credit_0.2
leverage: 1
manual_kill_switch: false
position_mode: HEDGE
sell_amounts_pct:
- 1.0
sell_spreads:
- 0.001
stop_loss: 0.003
take_profit: 2.0e-05
take_profit_order_type: 2
time_limit: 300
total_amount_quote: 30
trading_pair: BTC-FDUSD
trailing_stop:
activation_price: 0.018
trailing_delta: 0.002
Test: Set total_amount_quote where I use 15usd
- Creates buy and sell order at 7.5 ea
- When the market moves and its outside of the threshod 5% it places market order
- However because the order size is too small it returns retry error due to min order amount which
- To fix:
- User should be aware of this field and must add
skip_rebalance:truethen re-deploy the config from dashboard
- User should be aware of this field and must add
Steps to reproduce bug
- Create PMM simple controller-config with using the min order amount on dashboard then upload the config
- Check hummingbot-api ./bot/conf/controller pmm.simple controller configs
- Compare with market_making.pmm_simple controller config from standalone hummingbot
- Deploy a container on dashboard and observe when the bot creates order
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working