Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Deadlocks #664

Closed
mredig opened this issue Jan 25, 2025 · 6 comments
Closed

Test Deadlocks #664

mredig opened this issue Jan 25, 2025 · 6 comments

Comments

@mredig
Copy link
Contributor

mredig commented Jan 25, 2025

During my testing, I've noticed that sometimes tests just randomly hang. I assume this would be a known issue (and appears to be happening even in the cicd actions - some tests fail from cancellation after 15 minutes which I assume is just a timeout), but couldn't find any existing issues mentioning it.

I'm also assuming these are deadlocks. I've not investigated at all, but their behavior certainly acts that way.

Figured if there wasn't already an issue, we should at least have one open.

@adam-fowler
Copy link
Member

This seems to be an issue with Swift 6. It is the only build that is hanging?

@mredig
Copy link
Contributor Author

mredig commented Jan 26, 2025

I hadn't made that connection, but I'll pay attention as I test going forward.

It could be though - locally I'm testing with the Swift 6 toolchain, so that would be consistent with your suggestion.

@adam-fowler
Copy link
Member

I hadn't made that connection, but I'll pay attention as I test going forward.

It could be though - locally I'm testing with the Swift 6 toolchain, so that would be consistent with your suggestion.

I've only seen swift 6 fail in CI. Earlier versions of swift aren't.

@adam-fowler
Copy link
Member

Think I found the issue #666 (Nasty bug with exactly the right number of PR)

@mredig
Copy link
Contributor Author

mredig commented Jan 28, 2025

Think I found the issue #666 (Nasty bug with exactly the right number of PR)

Nice! Both for the fix and the appropriate number. :)

I'd make a review, but this is a bit beyond my understanding of the project internals, so I wouldn't have anything more to offer than a blank faced "lgtm". 😅

@adam-fowler
Copy link
Member

Fixed in 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants