Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tracer instead of LegacyTracer #258

Closed
natikgadzhi opened this issue Oct 30, 2023 · 2 comments · Fixed by #327
Closed

Use Tracer instead of LegacyTracer #258

natikgadzhi opened this issue Oct 30, 2023 · 2 comments · Fixed by #327

Comments

@natikgadzhi
Copy link

Now that we have Swift 5.7 minimum, we can use the new Tracer — not that we have to, LegacyTracer not being deprecated yet.

I don't think we're going to get a lot from having a concrete Span type either, in our case — if I'm reading it right, then we're setting the metadata here in TracingMiddleware.

Could be a good first issue for someone just playing around with Hummingbird and tracing?

@adam-fowler
Copy link
Member

Yeah I noticed we could update to using Tracer now. I hadn't got around to doing anything about it. Thank you for the issue. I'm happy to accept PRs as well to resolve this.

@natikgadzhi
Copy link
Author

natikgadzhi commented Oct 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants