Memory leak

[Cyberbeni]

I am serving a HTML site with a couple js/css files under 100kB and force reloading the site like 30 times causes a massive increase in memory consumption (and keeps increasing if I keep refreshing). Both Linux and macOS. Allocations recording with Instruments:

edit: the other 20% is probably HummingbirdWSCompression:

[adam-fowler]

Hmm that's not good. I had a quick look and while every deflateInit2 is paired with a deflateEnd it is still leaking memory.

[Cyberbeni]

deflateEnd calls deflateStateCheck, which seems to care if the z_streamp is still the same: https://github.com/madler/zlib/blob/develop/deflate.c#L535

So I think our z_stream instance needs to be wrapped in an UnsafeMutablePointer to ensure that's the case (like all the lock wrappers).

I'm not at a computer, can only try it later.

[adam-fowler]

The deflateEnd is returning ok as if it managed to free everything, but it doesn't as far as I can tell.