Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Security check fail with "padraic/humbug_get_contents" old version 1.0.4 #54

Open
charlesc-ai opened this issue Feb 19, 2018 · 6 comments

Comments

@charlesc-ai
Copy link

charlesc-ai commented Feb 19, 2018

Hello,
I have noticed an issue recently :
The package "padraic/phar-updater" requires "padraic/humbug_get_contents" version 1.0.4 but not newest version 1.1.2, which create failure in security check.

Are you going to update package "padraic/phar-updater" for solving this issue ?

Thanks in advance.


Symfony Security Check Report

// Checked file: /my_project/apache/volume/composer.lock

[ERROR] 1 packages have known vulnerabilities.

padraic/humbug_get_contents (1.0.4)

! [NOTE] This checker can only detect vulnerabilities that are referenced in
! the SensioLabs security advisories database. Execute this command
! regularly to check the newly discovered vulnerabilities.

Loaded config default from ".php_cs.dist".

@theofidry
Copy link
Member

Hi, the package should be permissive enough to allow you to upgrade to humbug/file_get_contents 1.1.2 as the constraint is ^1.0.

So what you should do here is to update your dependencies. You can force Composer to not install those vulnerable dependencies by requiring Roave SecurityAdvisories.

@pjcdawkins
Copy link

pjcdawkins commented Feb 19, 2018

Hi, the package should be permissive enough to allow you to upgrade to humbug/file_get_contents1.1.2 as the constraint is ^1.0.

GitHub might think that, but Packagist doesn't:

screen shot 2018-02-19 at 21 31 49

@theofidry I think you might need to click "Update" on Packagist, at least? until it shows the right constraint. (Maybe the 1.0.4 tag was force-pushed on this repo?)

@theofidry
Copy link
Member

Erf, indeed looks like there is quite a difference between the last release and master. I'll try to update that ASAP

theofidry added a commit to theofidry/phar-updater that referenced this issue Feb 20, 2018
theofidry added a commit that referenced this issue Feb 20, 2018
@theofidry
Copy link
Member

Done. Please upgrade to 1.0.5.

However keep in mind that if you are stuck on PHP 5.3, this won't work. Indeed newer versions of padraic/file_get_contents are not compatible with 5.3.

@pjcdawkins
Copy link

Thanks @theofidry!

@charlesc-ai
Copy link
Author

charlesc-ai commented Feb 22, 2018

@theofidry
Thanks, it works !
Just need to update both packages by "composer require padraic/phar-updater" and "composer require padraic/file_get_contents".
Have a nice day !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants