You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
In certain scenarios, a version can be injected into PHARs which is of the form: 1.0.0-26-gh378sj7.
The first part is a recognisable version number. The second part is the number of commits that the referenced build is ahead of the 1.0.0 tag by. The third part, prefixed with a g is the current commit hash.
The current solution (see #34) is to simple strip out the metadata, i.e. you end up with 1.0.0 as the normalised version. Clearly, that is not the correct answer. The correct answer is that this is a pre-release version not even marked alpha (i.e. it's 26 commits ahead of the actual 1.0.0). This tends to show up where versions are automated via box.
Solutions?
Inject pre-release marker if not already present (we can easily check if a pre-release label, like alpha is already attached). Probably use -dev if none already present: 1.0.0-26-gh378sj7 becomes 1.0.0-dev.26-gh378sj7
Strip the commit hash as useless information: 1.0.0-dev.26-gh378sj7 becomes 1.0.0-dev.26
Check if the revised version can be evaluation by Composer\Semver, and properly compared.
Other solution?
Report to Composer? I'm really not feeling this as being their problem though. Under Semver, one would expect metadata to be attached using a + sign. It's not!
Report to Box? That's more realistic, but they may have entirely alternative reasons for why this is valid.
The text was updated successfully, but these errors were encountered:
In certain scenarios, a version can be injected into PHARs which is of the form:
1.0.0-26-gh378sj7
.The first part is a recognisable version number. The second part is the number of commits that the referenced build is ahead of the
1.0.0
tag by. The third part, prefixed with ag
is the current commit hash.The current solution (see #34) is to simple strip out the metadata, i.e. you end up with
1.0.0
as the normalised version. Clearly, that is not the correct answer. The correct answer is that this is a pre-release version not even marked alpha (i.e. it's 26 commits ahead of the actual1.0.0
). This tends to show up where versions are automated via box.Solutions?
alpha
is already attached). Probably use-dev
if none already present:1.0.0-26-gh378sj7
becomes1.0.0-dev.26-gh378sj7
1.0.0-dev.26-gh378sj7
becomes1.0.0-dev.26
Other solution?
Report to Composer? I'm really not feeling this as being their problem though. Under Semver, one would expect metadata to be attached using a
+
sign. It's not!Report to Box? That's more realistic, but they may have entirely alternative reasons for why this is valid.
The text was updated successfully, but these errors were encountered: