Skip to content

Commit d19c768

Browse files
authored
Fix mistral with length > window_size for long prefills (rotary doesn't create long enough cos, sin). (#1571)
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ @OlivierDehaene OR @Narsil -->
1 parent 4139054 commit d19c768

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

server/text_generation_server/models/flash_mistral.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,10 @@ def forward(self, batch: FlashMistralBatch) -> Tuple[torch.Tensor, torch.Tensor]
460460
max_s = batch.max_seqlen
461461
lm_head_indices = batch.prefill_head_indices
462462

463-
if self.model.max_past is not None:
463+
if cu_seqlen_prefill is None and self.model.max_past is not None:
464+
# In decode, not prefill, we're actually overwriting the KV-cache
465+
# in a circular buffer mode.
466+
# This makes sure the max_s for the decode pass is correct.
464467
max_s = min(self.model.max_past, max_s)
465468

466469
bs = input_ids.shape[0]

0 commit comments

Comments
 (0)