HiDream pipeline update breaks downstream

@yiyixuxu

Describe the bug

HiDream pipeline is currently broken on diffusers main branch due to PR #11296 that was merged few days ago.
it introduces a bad deprecation check which simply fails on main branch.

Reproduction

N/A

Logs

│ /home/vlado/dev/sdnext/venv/lib/python3.12/site-packages/diffusers/models/transformers/transformer_hidream_image.py:794 in forward                                                                                                                                                                                                                                                                                               │
│                                                                                                                                                                                                                                                                                                                                                                                                                                  │
│   793 │   │   │   deprecation_message = "The `encoder_hidden_states` argument is deprecated. Please use `encoder_hidden_states_t5` and `encoder_hidden_states_llama3` instead."                                                                                                                                                                                                                                                  │
│ ❱ 794 │   │   │   deprecate("encoder_hidden_states", "0.34.0", deprecation_message)                                                                                                                                                                                                                                                                                                                                              │
│   795 │   │   │   encoder_hidden_states_t5 = encoder_hidden_states[0]                                                                                                                                                                                                                                                                                                                                                            │
│                                                                                                                                                                                                                                                                                                                                                                                                                                  │
│ /home/vlado/dev/sdnext/venv/lib/python3.12/site-packages/diffusers/utils/deprecation_utils.py:18 in deprecate                                                                                                                                                                                                                                                                                                                    │
│                                                                                                                                                                                                                                                                                                                                                                                                                                  │
│   17 │   │   if version.parse(version.parse(__version__).base_version) >= version.parse(version_name):                                                                                                                                                                                                                                                                                                                           │
│ ❱ 18 │   │   │   raise ValueError(                                                                                                                                                                                                                                                                                                                                                                                               │
│   19 │   │   │   │   f"The deprecation tuple {(attribute, version_name, message)} should be removed since diffusers'"                                                                                                                                                                                                                                                                                                            │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
ValueError: The deprecation tuple ('encoder_hidden_states', '0.34.0', 'The `encoder_hidden_states` argument is deprecated. Please use `encoder_hidden_states_t5` and `encoder_hidden_states_llama3` instead.') should be removed since diffusers' version 0.34.0.dev0 is >= 0.34.0

System Info

diffusers==main

Who can help?

@yiyixuxu @sayakpaul @a-r-r-o-w

@vladmandic

Hi @vladmandic, which transformers version are you using?
HiDream inference from main works fine for me

ok, it breaks custom hidream pipelines that were copied/modified and not updated to absolutely latest codebase.
i was using hidream cfgzero pipeline and it fails because it uses old-style encode_hidden_states format:

                noise_pred = self.transformer(
                    hidden_states=latent_model_input,
                    timesteps=timestep,
                    encoder_hidden_states=prompt_embeds,
                    pooled_embeds=pooled_prompt_embeds,
                    img_sizes=img_sizes,
                    img_ids=img_ids,
                    return_dict=False,
                )[0]

so yes, this is not affecting built-in pipeline. but deprecation is veeeery aggressive, not giving any chance downstream community to catch-up.

@vladmandic

hi @vladmandic let me move it to 0.35.0 (it was intended for after next release anyway)

lgtm, thanks!

Navigation Menu

Repository navigation

HiDream pipeline update breaks downstream #11382

Describe the bug

Reproduction

Logs

System Info

Who can help?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

HiDream pipeline update breaks downstream #11382

Description

Describe the bug

Reproduction

Logs

System Info

Who can help?

Activity

linoytsaban commented on Apr 22, 2025

vladmandic commented on Apr 22, 2025

yiyixuxu commented on Apr 22, 2025

vladmandic commented on Apr 22, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions