Priorities for contributions

[guiyrt]

Hey there, for the past few weeks I have been contributing on a few different topics, I've learned a lot and enjoyed every bit of the process (major kudos to diffusers team, especially @hlky who helped me on every single PR 😄). I was wondering what I could pick up next, and your input could be useful here, not only for me but for other people to pick up topics as well.

Other than the already open issues, from my previous PRs, I know these will come down the line, but I don't think they have issues associated with them yet:

• multi-image support for flux-ip-adapter-v2 (referenced in Support multiple IP adapter in Flux #10775)
• multi IP-Adapter for SD3
• IP-Adapter attention masking for SD3 and Flux

If you find these important, I think it would be nice creating issues with relevant information there for anyone to easily work on them. I could also help you out cleaning up past issues marked as "Good first issue", I noticed some are a few months old or already have an unmerged PR open, having these in order reduces friction for newcomers. I also seen mentioned you were considering experimenting with priority tags, I think that would help a lot clearing up which topics are more urgent.

I also think this would be a great addition:

• pre-push hooks for make style && make quality (at least). I think there is a non-insignificant number of PRs stale due to this, but pre-commit hooks might be a little too restrictive. Having this checked automatically and blocking pushing unformatted code is a valuable addition IMO.

I'm happy to help out with everything I mentioned, you are doing great work here and there's a lot more to come 🚀

[yiyixuxu]

hi @guiyrt
First of all, thanks for your contribution! We really appreciate it!

I don't think you should be looking for "Good first issue" though 😛 the PRs you've worked on are really not easy, and they're excellent work! so feel free to take up more challenge PRs!

For PRs with high priories, look for the "roadmap" label: if an issue is marked as "contribution welcome" and also "roadmap" it means this is super important to us. We are only opening them to the community because we do not have bandwidth for the moment and will start to work on them ourselves very soon. For this type of PRs we're looking for contributors with very good experience like yourself. We will work closely together, and may have to take over the PR depends on the timeline and progress, so before you open a PR, make sure that's something you're comfortable with:) totally understand if it is not. We currently ave sana contrinet open if you want to take a stab #10772

I will let @asomoza and @hlky comment how important are these ip-adapter related PRs
for make style, we recently intorduced this thanks to @sayakpaul! #10274

[guiyrt]

I don't think you should be looking for "Good first issue" though 😛

Yeah, totally, I was talking about cleaning issues that have been open or stale for a while (1y +), if you find that valuable

We currently ave sana contrinet open if you want to take a stab #10772

Sounds cool, I'll take a look when I have some time :)

for make style, we recently intorduced this thanks to @sayakpaul! #10274

I didn't know that, thanks for pointing it out! Yeah, that addresses it then

[asomoza]

For the IP Adapters IMO we should wait and see if people request them. I don't think they're used right now apart from the first initial test some people do, which doesn't involve multi IP Adapters or attention masking, so our best approach is that someone opens a feature request so we can keep track of them.

At this point with all the new image models and video models, it seems we could add additional complexity to the pipelines for something that isn't going to be used, I could be wrong, so that's why we should track them and wait.

[hlky]

Hi @guiyrt.

Sorry for the delay, you may have noticed the recent Remote VAE beta release which is consuming much of my bandwidth.

As @yiyixuxu mentioned, your contributions are appreciated, it's great to see the community take up challenging issues.

Multi-IPAdapter for SD3 would be a nice addition IMO, plus you have experience with it as you did the original contribution.

I'm not aware of IP-Adapter attention masking for SD3 and Flux support in other codebases, so it's untested/experimental but a worthwhile addition IMO. The same use cases as existing IP-Adapter masking would apply and the code should be similar.

Feel free to create issues to track these and take up either of them.

With regards to old issues/stale PRs I'd be onboard with priority tags, maybe the team can allocate some time each week to check the blockers on old issues/PRs and assign priorities. We have style bot now which should help. Maybe CONTRIBUTING.md could be updated with some policies like "we'll take over the PR if it's left for X amount of time". cc @yiyixuxu