Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update #109

Open
run-stop opened this issue Mar 13, 2023 · 2 comments
Open

Dependencies update #109

run-stop opened this issue Mar 13, 2023 · 2 comments

Comments

@run-stop
Copy link

My project is using the http-client v6.5.3. As of yesterday, compiler is issuing the deprecation warning.
I've traced the problem to the http-client using an old version of the deadpool crate (v0.7.0).

Would it be possible to upgrade the deadpoool crate version to something up to date?

@emmiegit
Copy link

emmiegit commented Apr 14, 2023

Echoing this.

Presently, the deadpool crate (version 0.7.0) depends on config 0.10.1, which depends on nom 5.1.2, which is using a deprecated rust feature producing a warning:

    Finished dev [unoptimized + debuginfo] target(s) in 4m 49s
warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 35`

The other dependencies in this chain are updated in this respect, so upgrading deadpool to 0.9.5 should resolve this warning.

@emmiegit
Copy link

Created the PR #110 to upgrade the dependency alone, hopefully it's a trivial enough set of changes so that the maintainer can resolve this issue without excessive effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants