Skip to content

Commit c6031dd

Browse files
author
howyi
committed
update access tasks
1 parent e90bada commit c6031dd

3 files changed

Lines changed: 29 additions & 6 deletions

File tree

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ $team->spaces()->objects();
4040
// -> \ClickUp\Objects\Space[]
4141

4242
// space by space id
43-
$space = $team->spaces()->getByKey(888);
43+
$space = $team->space(888);
4444
// space by name
4545
$space = $team->spaces()->getByName('spaaaaace');
4646
// -> \ClickUp\Objects\Space
@@ -51,7 +51,7 @@ $space->projects()->objects();
5151
// -> \ClickUp\Objects\Project[]
5252

5353
// project by project id
54-
$project = $space->projects()->getByKey(11111);
54+
$project = $space->project(11111);
5555
// project by name
5656
$project = $space->projects()->getByName('super cool project');
5757
// -> \ClickUp\Objects\Project
@@ -61,7 +61,7 @@ $project->taskLists()->objects();
6161
// -> \ClickUp\Objects\TaskList[]
6262

6363
// list by list id
64-
$taskList = $project->taskLists()->getByKey(9999);
64+
$taskList = $project->taskList(9999);
6565
// list by name
6666
$taskList = $project->taskLists()->getByName('T A S K L I S T');
6767
// -> \ClickUp\Objects\TaskList
@@ -71,7 +71,7 @@ $tasks = $taskList->tasks($teamId)->getCollection()->objects();
7171
// -> \ClickUp\Objects\Task[]
7272

7373
// task by task id
74-
$task = $client->tasks($teamId)->getByTaskId(3333);
74+
$task = $taskList->task(3333);
7575
// -> \ClickUp\Objects\Task
7676
```
7777

src/ClickUp/Objects/Project.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function setStatuses(StatusCollection $statuses)
120120
public function createTaskList($body)
121121
{
122122
return $this->client()->post(
123-
"project/$projectId/list",
123+
"project/{$this->id()}/list",
124124
$body
125125
);
126126
}

src/ClickUp/Objects/TaskFinderTrait.php

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,37 @@ trait TaskFinderTrait
99
/**
1010
* @return TaskFinder
1111
*/
12-
public function tasks()
12+
public function taskFinder()
1313
{
1414
return (new TaskFinder(
1515
$this->client(),
1616
$this->teamId()
1717
))->addParams($this->taskFindParams());
1818
}
1919

20+
/**
21+
* @param bool $includeSubTask
22+
* @param bool $includeClosed
23+
* @return TaskCollection
24+
*/
25+
public function tasks($includeSubTask = false, $includeClosed = false)
26+
{
27+
return $this
28+
->taskFinder()
29+
->includeSubTask($includeSubTask)
30+
->includeClosed($includeClosed)
31+
->getCollection();
32+
}
33+
34+
/**
35+
* @param int $taskId
36+
* @return Task
37+
*/
38+
public function task($taskId)
39+
{
40+
return $this->taskFinder()->getByTaskId($taskId);
41+
}
42+
2043
/**
2144
* @return int
2245
*/

0 commit comments

Comments
 (0)