Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Maarg jobs along with all the ofBiz jobs. #734

Open
3 tasks
amansinghbais opened this issue Oct 15, 2024 · 4 comments
Open
3 tasks

Show Maarg jobs along with all the ofBiz jobs. #734

amansinghbais opened this issue Oct 15, 2024 · 4 comments
Assignees
@shubham-namdeo
Labels
enhancement New feature or request release-v2.25.0

Comments

@amansinghbais
Copy link
Contributor

amansinghbais commented Oct 15, 2024 •
edited
Loading

What is the motivation for adding/enhancing this feature?

Moqui jobs are similar to OFBiz jobs. We should find a way to show those jobs along with our ofBiz jobs. And allow scheduling of those jobs.

Related doc: https://docs.google.com/document/d/1MtH6s02NZcnX4FI-ujTgbz4ZBZVYTrywX-OZbMugQrA/edit

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@amansinghbais amansinghbais self-assigned this Oct 15, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Oct 15, 2024
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 14, 2024
@amansinghbais
Implemented: support for getting respective maarg url and token for t…
50cbd0b 
…he loggedIn oms (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 14, 2024
@amansinghbais
Implemented: logic for fetching maarg job based on jobName (hotwax#734)
c75bb23
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 14, 2024
@amansinghbais
Implemeted: support for showing maarg jobs in the app (hotwax#734)
59779b5
@amansinghbais amansinghbais mentioned this issue Nov 14, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 15, 2024
@amansinghbais
Improved: support to check and refresh current job if the nextExecuti…
4304ade 
…on time is passed (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 15, 2024
@amansinghbais
Improved: fetching the enums and showing enumName as jobName on UI (h…
58fe9f1 
…otwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 15, 2024
@amansinghbais
Improved: clearing jobEnums on logout of the app (hotwax#734)
a926d7f
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 15, 2024
@amansinghbais
Improved: baseUrl to fetch enumeration from atp component for accessi…
0d4f6cb 
…ng maarg enum table (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 26, 2024
@amansinghbais
Implemented: maarg jobs in the inventory, misc, orders and preorder p…
579d644 
…age (hotwax#734)
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Nov 26, 2024
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 28, 2024
@amansinghbais
Improved: added entry in the env for the maarg job enums (hotwax#734)
6af3916
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 29, 2024
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/job-manager into hot…
6e7541c 
…wax#734-maarg-jobs
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 2, 2024
@amansinghbais
Improved: mutation names for maargjob store, updated env entry name f…
a33148b 
…or maarg job enums (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 3, 2024
@amansinghbais
Improved: added all the maarg job entries and their labels on the ui (h…
3345c69 
…otwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 3, 2024
@amansinghbais
Improved: added entry in locale for the missing translation of static…
1b873c4 
… texts (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 5, 2024
@amansinghbais
Improved: UI of the misc jobs, enumDescription to be shown in the his…
d574f54 
…tory modal (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Improved: components import in the maarg job configuration component …
4903a07 
…and remove check for job endtime from ion-item (hotwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Reverted: unwanted imports and parameters in the code (hotwax#734)
1f09688
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Improved: imported the Ionlist in the maargJobConfiguration component (…
f585b0c 
…hotwax#734-maarg-jobs)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Reverted: changes made in the convertValue util method (hotwax#734-ma…
38187cd 
…arg-jobs)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Reverted: unwanted imports/changes, used logger instead of console (h…
cce65aa 
…otwax#734)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Reverted: unused import and the parameter (hotwax#734)
557de0c
ymaheshwari1 added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@ymaheshwari1
Merge branch 'main' into hotwax#734-maarg-jobs
1b6511e
ymaheshwari1 added a commit that referenced this issue Dec 6, 2024
@ymaheshwari1
Merge pull request #744 from amansinghbais/#734-maarg-jobs
70827e4 
Implemeted: support for showing maarg jobs in the app (#734)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Dec 6, 2024
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 6, 2024
@amansinghbais
Implemented: mobile view for the maarg jobs (hotwax#734-maarg-job-mob…
3539dbd 
…ile)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 9, 2024
@amansinghbais
Fixed: category for the inventory router push and name (hotwax#734)
1d06675
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Dec 10, 2024
@amansinghbais
Improved: clearing the currentMaargJob from state when changing the p…
7b561a4 
…age (hotwax#734)
ravilodhi added a commit that referenced this issue Dec 11, 2024
@ravilodhi
Merge pull request #753 from amansinghbais/#734-maarg-job-mobile
8b9b8b9 
Implemented: mobile view for the maarg jobs (#734)
@Adameddy26 Adameddy26 added enhancement New feature or request release-v2.25.0 labels Dec 24, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Dec 24, 2024
@AjinkyaM1
Copy link

After testing these changes, the following issues were found:

  1. When scheduling a job and selecting a large schedule, such as At 0 minutes past the hour, every 6 hours, the UI breaks on the job list page. The schedule is not clear from its name.
  2. After scheduling the job, the job name changes from "Poll OMS Fulfilled Items Feed" to [poll_OMSFulfillmentFeed_DEV].
  3. The Running status does not appear to update with the latest run time.
  4. Additional parameters do not seem to be added to the job.

Jam: https://jam.dev/c/256ac4f9-47f8-43ed-9062-1571a483350e

@Adameddy26 Adameddy26 moved this from ⚒️ In QA to 📅 Planned in Digital Experience Platform Jan 7, 2025
@Adameddy26
Copy link

Assigning it back to dev for the fixes required.

amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Jan 13, 2025
@amansinghbais
Fixed: additional parameter updating issue and id showing instead of …
4ea520e 
…job description once updating job (hotwax#734)
@amansinghbais amansinghbais mentioned this issue Jan 13, 2025
Merged
1 task
@amansinghbais amansinghbais moved this from 📅 Planned to 👀 In review in Digital Experience Platform Jan 13, 2025
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Jan 23, 2025
@amansinghbais
Improved: logic for refetching the current job (hotwax#734)
2b07a20
ymaheshwari1 added a commit to amansinghbais/job-manager that referenced this issue Jan 23, 2025
@ymaheshwari1
Merge branch 'main' into hotwax#734-fixes
53d5e9d
ymaheshwari1 added a commit that referenced this issue Jan 23, 2025
@ymaheshwari1
Merge pull request #760 from amansinghbais/#734-fixes
0df7c2f 
Fixed: additional parameter updating issue and id showing instead of job description once updating job (#734)
@amansinghbais amansinghbais moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 23, 2025
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Jan 29, 2025
@AjinkyaM1
Copy link

Tested the above-mentioned issues, and it seems like the issue still exists in the UAT version of the app. The additional parameter issue appears to be fixed.

amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Jan 30, 2025
@amansinghbais
Fixed: maarg job enum description not showing up while first time fet…
f195dc7 
…ching of the maargjobs (hotwax#734)
@amansinghbais amansinghbais mentioned this issue Jan 30, 2025
Merged
1 task
@amansinghbais
Copy link
Contributor Author

Here in the 3rd issue, the nextExecution time is automatically generated by moqui, based on frequency provided and the old nextExecution time. Hence can't do anything from frontend side.

ymaheshwari1 added a commit that referenced this issue Jan 31, 2025
@ymaheshwari1
Merge pull request #766 from amansinghbais/#734-fixes
caab1d9 
Fixed: maarg job enum description not showing up while first time fetching of the maargjobs (#734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubham-namdeo shubham-namdeo

Labels
enhancement New feature or request release-v2.25.0
Projects
Digital Experience Platform
Status: ⚒️ In QA
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amansinghbais @AjinkyaM1 @Adameddy26 @shubham-namdeo