Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learn More #726

Closed
dt2patel opened this issue Sep 2, 2024 · 8 comments
Closed

Learn More #726

dt2patel opened this issue Sep 2, 2024 · 8 comments
Assignees
@Adameddy26
Labels
enhancement New feature or request release-v2.25.0 release-v2.26.0

Comments

@dt2patel
Copy link
Contributor

dt2patel commented Sep 2, 2024

What is the motivation for adding/enhancing this feature?

Allow users to quickly search about jobs from Job Manager to get a better understanding of specific jobs without having to leave the app.

Screenshot 2024-09-02 at 4 54 39 PM They can either click on learn more from the description of a job detail section or click on the info icon at the end of the they job enum item on the job card.
@dt2patel dt2patel added the enhancement New feature or request label Sep 2, 2024
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Sep 2, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Oct 4, 2024
@ravilodhi ravilodhi removed their assignment Oct 7, 2024
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Oct 8, 2024
@R-Sourabh
Implemented: 'Learn More' functionality that generates job info from …
a159f58 
…GitBook Lens APIs (hotwax#726)
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Oct 8, 2024
@R-Sourabh
Improved: added outline attribute in the ion-chip(hotwax#726)
d777bc5
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Oct 8, 2024
@R-Sourabh
Improved: change the ion-item property in the card on pipeline page(h…
ee62280 
…otwax#726)
@R-Sourabh R-Sourabh mentioned this issue Oct 8, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Oct 8, 2024
@R-Sourabh
Improved: updated the .env.example with gitbook urls & key(hotwax#726)
8966a97
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Oct 8, 2024
@R-Sourabh
Improved: upgraded the oms-api version for gitbook apis(hotwax#726)
7a4c0ab
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Oct 9, 2024
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Oct 28, 2024
@R-Sourabh
Reverted: updated the env file with new changes(hotwax#726)
d60b768
@R-Sourabh
Copy link
Contributor

Implemented the logic and added a "Learn More" modal that displays job information generated from the GitBook Lens API and includes a link to the GitBook article source. Currently, I am marking this ticket as on hold because the documents need structural changes, as the GitBook Lens APIs fetch data based on them.

@R-Sourabh R-Sourabh moved this from 👀 In review to 🛑 On hold in Digital Experience Platform Nov 20, 2024
@dt2patel
Copy link
Contributor Author

Let's merge this into develop since we have GitBook AI running now. We can test this and marketing team can help fine tune content before release @ravilodhi

R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 27, 2024
@R-Sourabh
Merge branch 'main' into hotwax#726-Learn-more
d0e255c
@ravilodhi
Copy link
Contributor

Sure, let me check the PR.
@dt2patel

R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 27, 2024
@R-Sourabh
Improved: added locale text & changed the component name(hotwax#726)
3d5326e
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 27, 2024
@R-Sourabh
Improved: update empty-state check, arrange ionic component imports &…
4887cfb 
… wrapped ion-button into ion-buttons(hotwax#726)
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 27, 2024
@R-Sourabh
Improved: added locale text, added slot property on ion-icon & color …
2872cc4 
…to ion-button(hotwax#726)
@R-Sourabh R-Sourabh moved this from 🛑 On hold to 👀 In review in Digital Experience Platform Nov 27, 2024
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 27, 2024
@R-Sourabh
Improved: passed the "noopener, noreferrer" in windows.open function(h…
1fc69f0 
…otwax#726)
ravilodhi added a commit that referenced this issue Nov 27, 2024
@ravilodhi
Merge pull request #730 from R-Sourabh/#726-Learn-more
d889a34 
Implemented: 'Learn More' functionality that generates job info from GitBook Lens APIs (#726)
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Nov 27, 2024
@dt2patel
Copy link
Contributor Author

dt2patel commented Nov 27, 2024 •
edited
Loading

Facing issue where API is not returning an answer:

Screenshot 2024-11-27 at 5 57 52 PM

@ravilodhi
Copy link
Contributor

@dt2patel Try now. Actually, there are some environment variables that need to be set as organization secrets and supported in the auto-deployment action. Deployed the Job Manager dev manually.

R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 28, 2024
@R-Sourabh
Reverted: removed the caret sign from oms-api in package.json file(ho…
5f0a938 
…twax#726)
@R-Sourabh R-Sourabh mentioned this issue Nov 28, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Nov 28, 2024
@R-Sourabh
Improved: updated the oms-api version & passed token in getShopifyCon…
8e660ab 
…fig service using client method(hotwax#726)
ymaheshwari1 added a commit to R-Sourabh/job-manager that referenced this issue Nov 28, 2024
@ymaheshwari1
Merge branch 'main' into hotwax#726-Learn-more
b6a2d5c
ymaheshwari1 added a commit that referenced this issue Nov 28, 2024
@ymaheshwari1
Merge pull request #748 from R-Sourabh/#726-Learn-more
ae4de84 
Fixed: removed the caret sign from oms-api in package.json file, used oms-api version 15.0 and passed token in client method as required in oms-api v15(#726)
@AjinkyaM1
Copy link

Found two scenarios: one where the summary is present but the sources are empty, and another where both the summary and sources are empty. In such cases, should there be a message displayed to the user indicating that the document is not available for this job? For example:
No document is currently available for the selected job. Please try again later.

Jam: https://jam.dev/c/a599d436-3c3b-4759-94f5-1fd00e7ef7ff

@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 📅 Planned in Digital Experience Platform Jan 7, 2025
@Adameddy26
Copy link

@R-Sourabh Please have a look on the comments added

@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jan 9, 2025
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Jan 9, 2025
@R-Sourabh
Improved: Added checks for various cases on the "Learn More" modal(ho…
adda43b 
…twax#726)

- If a summary is not present for a job, an empty state will appear on the modal.
- If sources are not present for any reason, the summary may still be visible on the modal.
@R-Sourabh R-Sourabh mentioned this issue Jan 9, 2025
Merged
1 task
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 9, 2025
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this issue Jan 9, 2025
@R-Sourabh
Improved: Refactor empty state condition to remove redundant parenthe…
fc393e7 
…ses(hotwax#726)
ymaheshwari1 added a commit that referenced this issue Jan 10, 2025
@ymaheshwari1
Merge pull request #759 from R-Sourabh/#726-Learn-more
ec37509 
Improved: Added checks for various cases on the "Learn More" modal(#726)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 10, 2025
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Jan 30, 2025
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Jan 30, 2025
@ymaheshwari1
Copy link
Contributor

Tested this previously and was working fine, but currently the learn more functionality stopped working due to change in the response structure. So the mentioned issues can't be verified again, so closing this issue for now.

@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-v2.25.0 release-v2.26.0
Projects
Digital Experience Platform
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ravilodhi @ymaheshwari1 @dt2patel @R-Sourabh @AjinkyaM1 @Adameddy26