Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job configuration card should dismiss when refreshing jobs due to product store change #720

Open
3 tasks
amansinghbais opened this issue Aug 8, 2024 · 2 comments
Open
3 tasks

Job configuration card should dismiss when refreshing jobs due to product store change #720

amansinghbais opened this issue Aug 8, 2024 · 2 comments
Assignees
@amansinghbais

Comments

@amansinghbais
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently when job configuration of a job is open, and user changes the product store. The jobs list refreshes but the previous job configuration card doesn't updates.

Instead when user changes the product store the job configuration card should close while refreshing jobs.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@amansinghbais amansinghbais self-assigned this Aug 8, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Aug 8, 2024
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Aug 9, 2024
@amansinghbais
Improved: logic to show spinner and close configuration card in case …
68d636b 
…of product store change (hotwax#720)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Aug 9, 2024
@amansinghbais
Improved: added missing locale entry for the spinner static text (hot…
b682ade 
…wax#720)
@amansinghbais amansinghbais mentioned this issue Aug 9, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Aug 9, 2024
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 25, 2024
@amansinghbais
Reverted: unnecessary arguments being passed, and unwanted await keyw…
0eed41f 
…ord (hotwax#720)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 25, 2024
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/job-manager into hot…
6365792 
…wax#720
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 25, 2024
@amansinghbais
Improved: code to only dismiss the configuration card in case of prod…
7e556a9 
…uct store change (hotwax#720)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 25, 2024
@amansinghbais
Reverted: unwanted console statement from the code (hotwax#720)
ebf49f2
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 26, 2024
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/job-manager into hot…
54259ee 
…wax#720
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 26, 2024
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/job-manager into hot…
27ac99e 
…wax#720
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 26, 2024
@amansinghbais
Reverted: unwanted spinner on the pages since we have added skeleton …
b35df66 
…text (hotwax#720)
amansinghbais added a commit to amansinghbais/job-manager that referenced this issue Nov 29, 2024
@amansinghbais
Improved: updated the variable name for clearing current job for bett…
1ebfa47 
…er understanding (hotwax#720)
ymaheshwari1 added a commit to amansinghbais/job-manager that referenced this issue Nov 29, 2024
@ymaheshwari1
Merge branch 'main' into hotwax#720
7e0ebb0
ymaheshwari1 added a commit that referenced this issue Nov 29, 2024
@ymaheshwari1
Merge pull request #721 from amansinghbais/#720
929ebca 
Improved: logic to show spinner and close configuration card in case of product store change (#720)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Nov 29, 2024
@AjinkyaM1
Copy link

AjinkyaM1 commented Jan 2, 2025 •
edited
Loading

The changes seem to work fine. When the job configurations card is opened and the product store is changed, the configuration card closes as expected. Additionally, the spinner rotates while loading the jobs for the selected product store.
When the app is used on a 3G network, there seems to be a lag of a few seconds. The spinner starts rotating, but the job configuration card remains visible for a few seconds

@Adameddy26
Copy link

@AjinkyaM1 Can you please add a recording here to get more clarity on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amansinghbais amansinghbais

Labels
None yet
Projects
Digital Experience Platform
Status: ⏸️ Dev complete
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amansinghbais @AjinkyaM1 @Adameddy26