New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with multiple component registration if multiple libraries import this lib #71

Open

spwoodcock opened this issue Feb 3, 2025 · 0 comments

Labels

bug

Member

spwoodcock commented Feb 3, 2025

Describe the bug

In DroneTM we import hotosm/ui for the tracking banner.
DroneTM also uses the hotosm/gcp-editor component, which uses hotosm/ui underneath.
We get an error that the components are imported twice.

Expected behavior

The imports are conditional, only if the element name does not exist in the custom element registry already?
Perhaps something like this?

if (!customElements.get('hot-tracking')) {
  customElements.register(...)
}

Additional context

Or perhaps this is just due to incorrect usage of the lib?
gcp-editor imports all the components as a bundle.
For packages that may be installed, they should probably selectively import components?

spwoodcock added the bug label

spwoodcock added this to Shared UI

github-project-automation bot moved this to Backlog in Shared UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment