List of users is not populated for super admin

[manjitapandey]

Describe the bug
When admin user tries to view the list of users from manage section, the list of user is not populated and upon inspection there is 400 bad request error message on network panel

To Reproduce
Steps to reproduce the behavior:
Make sure you have an admin role

1. Go to 'manage tab'
2. Click on 'manage users'
3. See error

Expected behavior
The list of users should be populated

Screenshots

Additional context
the error message is as below:
"errors": [
{
"loc": [
"query",
"project_id"
],
"msg": "Field required",
"error": "Field required['query', 'project_id']"
}
]
}
for
https://api.stage.fmtm.hotosm.org/users?results_per_page=13&page=1&search=

[spwoodcock]

I think the frontend just needs

?project_id={projectId}

[NSUWAL123]

I think the frontend just needs

?project_id={projectId}

No @spwoodcock. The /users API is used in the manage-users section as well as in the create project (display user list to assign project admin). So it's not possible to pass ?project_id={projectId} param

[spwoodcock]

Well that makes sense then. I just assumed that was the fix based on the error.

So you are suggesting we might need separate endpoints for both?

On a side note, I personally still don't understand why we need this functionality in the frontend - its close to the very bottom of what I see for FMTM priorities 😅 (along with any admin-specific frontend functionality)

[NSUWAL123]

I assume the manage users page was the top priority as we discussed in the meeting last month 🤔

[NSUWAL123]

We will be using the user API in many places as well as in the user tagging feature in comments. But I didn't understand why project_id is needed to pass in the user's API.

[spwoodcock]

I assume the manage users page was the top priority as we discussed in the meeting last month 🤔

Oh my bad then, if Ramya and Manjita agree its priority then ignore me, sorry!
(I don't necessarily agree - I think writing a UI for one admin user isn't the best idea 😅)

However, that said, if we could reuse this component for managing users at a project level too (for project admins), then its a great idea 👍

[spwoodcock]

My main concern is not writing a load of additional code specifically for the admin user.

On the backend we need to pass the project id generally, to determine the user roles.

However in this case we can adapt the logic probably to make passing project id optional.

• If no id, check if user is admin, return all users
• If id included, check if user is at least project manager, return filtered users