Tent: Scoped stores fire different events than the regular store

[espy]

Scoped stores emit events differently than the regular store, and sometimes don't emit the correct events at all, instead only ever emitting update instead of remove, for example.

The pattern seems to be that add and remove are be mutually exclusive, only the first listener of the two ever works.

To reproduce

In an empty directory, npm init -y and hit enter until done. Install the tent release: npm i hoodie --save --no-optional. Open package.json and add this into the root object:

"scripts": {
  "start": "hoodie"
}

Add a public/index.html file that has <script src="/hoodie/client.js"></script> in it, then start the app with npm start -- --inMemory

Now, open the Hoodie app in an incognito browser tab and set up some listeners in the dev console, to observe that regular store works as expected:

hoodie.store.on('add', function(person){
  console.log('add')
})

hoodie.store.on('remove', function(person){
  console.log('remove')
})

hoodie.store.on('update', function(person){
  console.log('update')
})

hoodie.store.on('change', function(event, person){
  console.log('change ',event)
})

Then add a person:

hoodie.store().add({
   type: 'person',
   name: 'knut'
})

This logs add and change add, as expected.

Now reload the page, then do the same with a scoped store:

hoodie.store('person').on('add', function(person){
  console.log('add ')
})

hoodie.store('person').on('remove', function(person){
  console.log('remove')
})

hoodie.store('person').on('update', function(person){
  console.log('update')
})

hoodie.store('person').on('change', function(event, person){
  console.log('change ',event)
})

hoodie.store('person').add({
   name: 'horst'
})

This logs add, update, and change update, when it should log add and change add.

Here's the serious bit:

If you now hoodie.store('person').removeAll(), no remove event is fired at all, only update and change update. If you reload the page and do everything again, but register remove before add, you'll get remove, update, and change update whenever you remove something, but no add event when you add a person, only an update.

[sebbel]

I could reproduce the error.

[gr2m]

@sebbel can you try to create a test reproducing the error? Alex will be out until next week

[sebbel]

I'd be happy to.

[gr2m]

I wasn’t able to reproduce last bit:

If you reload the page and do everything again, but register remove before add, you'll get remove, update, and change update whenever you remove something, but no add event when you add a person, only an update.

When I run

hoodie.store('person').on('remove', function(person){
  console.log('remove')
})

hoodie.store('person').on('add', function(person){
  console.log('add ')
})

hoodie.store('person').on('update', function(person){
  console.log('update')
})

hoodie.store('person').on('change', function(event, person){
  console.log('change ',event)
})

hoodie.store('person').add({
   name: 'horst'
})

.then(function () {
  hoodie.store('person').removeAll()
}); 

I get this in my console log

update
change update
update
change update

But no remove log

[courajs]

I did notice I was getting updates instead of removes, and had a small test repro here

[gr2m]

please see the discussion on the .type property and the hoodie.store(scope) API: hoodiehq/discussion#106

[gr2m]

this should be resolved now with hoodie.store.withIdPrefix()